policy share_snapshot inconsistency

[Maurice Escher]

Hi, when adjusting the policy.json I noticed an inconsistency:

The following rules

"share:create_snapshot"
"share:delete_snapshot"
"share:snapshot_update"

should be renamed to

"share_snapshot:create_snapshot"
"share_snapshot:delete_snapshot"
"share_snapshot:snapshot_update"

to have a more consistent pattern.

Please also consider updating the test policy (where the former format is present) and the provided example policy file (where the latter format is present).

Thanks.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/436992

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/436992
Committed: https://git.openstack.org/cgit/openstack/manila/commit/?id=87f9a81b75947a8cf6866422be483c8763c3bc71
Submitter: Jenkins
Branch: master

commit 87f9a81b75947a8cf6866422be483c8763c3bc71
Author: Marc Koderer <email address hidden>
Date: Wed Feb 22 16:40:28 2017 +0100

    Align policy.json with code

    Snapshot policy is named inconsistently. Fixing this in the code
    would cause a migration conflict since both "share:create_snapshot"
    and "share_snapshot:create_snapshot" need to be supported. Instead
    this fixes only policy.json

    Change-Id: I5869f53ac5086d7411dc3553b4cf88423b7524f5
    Closes-bug: #1666498

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/manila 5.0.0.0b1 development milestone.