container driver log msg uses neutron subnet id for network id

Bug #1665777 reported by Tom Barron
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Shared File Systems Service (Manila)
Fix Released
Undecided
Tom Barron

Bug Description

When connecting a container to a neutron network, the container driver logs a message such as:

2017-02-17 19:26:08.490 30684 DEBUG manila.share.drivers.container.driver [req-b5b1e345-5646-4aab-9af9-5420bc2b157f - - - - -] Now container manila_d825e4fd_76eb_493a_8246_7ad39512c838 should be accessible from network c5b432c8-7c5e-495f-b1da-ac8f34ae96cd by address 10.1.0.9. _connect_to_network /opt/stack/new/manila/manila/share/drivers/container/driver.py:257

But the value it is supplying for the network id is in fact the subnet id from the supplied network info, not the network id.

fedora@fedora0 manila]$ openstack network list
+--------------------------------------+---------+----------------------------------------------------------------------------+
| ID | Name | Subnets |
+--------------------------------------+---------+----------------------------------------------------------------------------+
| 440740d2-9fc1-4b3a-af94-80dae4e1a05b | public | c80b8b9b-f7b2-4769-bcb2-6d4e7eb6d325, c820e0c1-ee3e-4142-af10-a6cf928620bb |
| e72792e7-c20b-4b25-8447-a0c0e52b8e6b | private | 0e5ae350-441b-4e8c-8792-254a5bf65585, c5b432c8-7c5e-495f-b1da-ac8f34ae96cd |
+--------------------------------------+---------+----------------------------------------------------------------------------+
[fedora@fedora0 manila]$ openstack subnet show c5b432c8-7c5e-495f-b1da-ac8f34ae96cd
+-------------------+--------------------------------------+
| Field | Value |
+-------------------+--------------------------------------+
| allocation_pools | 10.1.0.2-10.1.0.62 |
| cidr | 10.1.0.0/26 |
| created_at | 2017-02-13T19:11:38Z |
| description | |
| dns_nameservers | |
| enable_dhcp | True |
| gateway_ip | 10.1.0.1 |
| host_routes | |
| id | c5b432c8-7c5e-495f-b1da-ac8f34ae96cd |
| ip_version | 4 |
| ipv6_address_mode | None |
| ipv6_ra_mode | None |
| name | private-subnet |
| network_id | e72792e7-c20b-4b25-8447-a0c0e52b8e6b |
| project_id | add51d44a3d046ca9d01ab7391c318f5 |
| revision_number | 2 |
| segment_id | None |
| service_types | |
| subnetpool_id | 80a48e71-33ac-449e-b0a0-f7fbd0f30a39 |
| updated_at | 2017-02-13T19:11:38Z |
+-------------------+--------------------------------------+

Tom Barron (tpb)
Changed in manila:
assignee: nobody → Tom Barron (tpb)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to manila (master)

Fix proposed to branch: master
Review: https://review.openstack.org/435597

Changed in manila:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to manila (master)

Reviewed: https://review.openstack.org/435597
Committed: https://git.openstack.org/cgit/openstack/manila/commit/?id=0212756b656b8b69ba13bab6d70d1c16e7a0cc02
Submitter: Jenkins
Branch: master

commit 0212756b656b8b69ba13bab6d70d1c16e7a0cc02
Author: Tom Barron <email address hidden>
Date: Mon Feb 20 15:59:11 2017 +0000

    container driver: log network id as network id

    Instead of supplying a neutron subnet id and calling it a
    neutron network id.

    Closes-bug: #1665777

    Change-Id: I754f95629f85a83fc3eb16e25c25e619e3966dd4

Changed in manila:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/manila 5.0.0.0b1

This issue was fixed in the openstack/manila 5.0.0.0b1 development milestone.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.