OpenStack Shared File Systems Service (Manila)

Broken Windows share helper

Bug #1663300 reported by Lucian Petrut on 2017-02-09

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	OpenStack Shared File Systems Service (Manila)	Fix Released	Medium	Lucian Petrut	OpenStack Shared File Systems Service (Manila) ocata-rc2 "RC2"

Bug Description

The Windows SMB driver inherits the Generic driver, reusing most
of its logic.

The following change broke the Windows SMB driver and helpers,
changing a few method signatures and return values:
I6e7eca54725d1aef994d617f253e73909a9d8303

Tags:

OpenStack Infra (hudson-openstack) on 2017-02-09

Changed in manila:
assignee:	nobody → Lucian Petrut (petrutlucian94)
status:	New → In Progress

Lucian Petrut (petrutlucian94) on 2017-02-09

tags:

added: ocata-backport-potential

Valeriy Ponomaryov (vponomaryov) on 2017-02-09

Changed in manila:
milestone:	none → pike-1
importance:	Undecided → Critical

Revision history for this message

Ben Swartzlander (bswartz) wrote on 2017-02-09:

Driver bugs aren't critical, marking medium priority.

Changed in manila:
importance:	Critical → Medium

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2017-02-10: Fix merged to manila (master)

Reviewed: https://review.openstack.org/424112
Committed: https://git.openstack.org/cgit/openstack/manila/commit/?id=4e6be9ab3c899620440d1bfff3e37606ea60cd2b
Submitter: Jenkins
Branch: master

commit 4e6be9ab3c899620440d1bfff3e37606ea60cd2b
Author: Lucian Petrut <email address hidden>
Date: Mon Jan 23 15:22:22 2017 +0200

Fix Windows SMB helper

The Windows SMB driver inherits the Generic driver, reusing most
of its logic.

    The following change broke the Windows SMB driver and helpers,
    changing a few method signatures and return values:
    I6e7eca54725d1aef994d617f253e73909a9d8303

This patch fixes the Windows SMB helper based on the above mentioned
change.

Closes-Bug: #1663300

Change-Id: I1ce56ba8abaddda1bf3f0b885f72ad713f36de56

Changed in manila:
status:	In Progress → Fix Released

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2017-02-13: Fix proposed to manila (stable/ocata)

Fix proposed to branch: stable/ocata
Review: https://review.openstack.org/433094

Ben Swartzlander (bswartz) on 2017-02-15

tags:	added: ocata-rc2-potential removed: ocata-backport-potential
Changed in manila:
milestone:	pike-1 → ocara-rc2

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2017-02-17: Fix merged to manila (stable/ocata)

Reviewed: https://review.openstack.org/433094
Committed: https://git.openstack.org/cgit/openstack/manila/commit/?id=3a9476027d3551b28de10afce04ab6407f644dcb
Submitter: Jenkins
Branch: stable/ocata

commit 3a9476027d3551b28de10afce04ab6407f644dcb
Author: Lucian Petrut <email address hidden>
Date: Mon Jan 23 15:22:22 2017 +0200

Fix Windows SMB helper

The Windows SMB driver inherits the Generic driver, reusing most
of its logic.

    The following change broke the Windows SMB driver and helpers,
    changing a few method signatures and return values:
    I6e7eca54725d1aef994d617f253e73909a9d8303

This patch fixes the Windows SMB helper based on the above mentioned
change.

Closes-Bug: #1663300

Change-Id: I1ce56ba8abaddda1bf3f0b885f72ad713f36de56
(cherry picked from commit 4e6be9ab3c899620440d1bfff3e37606ea60cd2b)

tags:

added: in-stable-ocata

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2017-02-17: Fix included in openstack/manila 4.0.0.0rc2

This issue was fixed in the openstack/manila 4.0.0.0rc2 release candidate.

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2017-04-13: Fix included in openstack/manila 5.0.0.0b1

This issue was fixed in the openstack/manila 5.0.0.0b1 development milestone.