subsequent snapshot access rules always go to error state when one rule is in error

Bug #1660425 reported by Rodrigo Barbieri
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Shared File Systems Service (Manila)
Fix Released
Rodrigo Barbieri

Bug Description

Whenever adding snapshot access rules to a mountable snapshot, if one rule is in error, all subsequent rules will be in error for drivers that always look at "access_rules" parameter. Error'ed rules should not be passed down to drivers in subsequent snapshot-access-allow calls.

Changed in manila:
importance: Undecided → Medium
assignee: nobody → Rodrigo Barbieri (rodrigo-barbieri2010)
milestone: none → ocata-rc1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to manila (master)

Fix proposed to branch: master

Changed in manila:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to manila (master)

Submitter: Jenkins
Branch: master

commit 4f330330d59739ec6549a1d83096e8334e8bbe0c
Author: Rodrigo Barbieri <email address hidden>
Date: Mon Jan 30 15:56:03 2017 -0200

    Fix error'ed access rules being sent to driver

    Error'ed snapshot access rules should not be sent down to drivers,
    as drivers that only look at 'access_rules' parameter will always
    try to apply them, causing every subsequent call to result in
    error. They should only be sent to drivers when being removed.

    Change-Id: Icf7e87d82eb0d51d441cd813da146cc0965fa334
    Closes-bug: #1660425

Changed in manila:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/manila

This issue was fixed in the openstack/manila release candidate.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.