share migration does not detect share-group-snapshots

[Rodrigo Barbieri]

Share migration has 2 behaviors when it comes to snapshots:

1) host-assisted migration cannot migrate snapshots, so it should error-out.
2) driver-assisted migration, when driver supports it, can migrate snapshots.

Currently, if share is member of a group, and has a group snapshot, share migration is allowing the migration to start. In case of a host-assisted migration, it is not detecting the presence of any snapshots, and is proceeding with the migration.

Steps to reproduce:

1) create share group X in host W
2) create share Y in group X
3) create a group snapshot Z of group X
4) attempt to migrate share Y to host U
5) migration will succeed. If using the generic driver, it will fail to delete the source instance, as it has snapshots, but will delete anyway, leaving the group-snapshot inconsistent.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/427834

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/427834
Committed: https://git.openstack.org/cgit/openstack/manila/commit/?id=26c803ea95b7e9b00822a867fc4b9bc04a4f10d4
Submitter: Jenkins
Branch: master

commit 26c803ea95b7e9b00822a867fc4b9bc04a4f10d4
Author: Rodrigo Barbieri <email address hidden>
Date: Wed Feb 1 15:41:03 2017 -0200

    Blocked migration of shares within share groups

    In Ocata, coordination between share migration and share groups
    features was not implemented. So, restrict its usage for now.

    APIImpact

    Change-Id: Id15453590685aa9c7788e79a33ca98b4dcc8a3ea
    Closes-bug: #1660336
    Closes-bug: #1660319

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/manila 4.0.0.0rc1 release candidate.