Share Group Type - add does not allow share type name

Bug #1659625 reported by Richard Hagarty
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Shared File Systems Service (Manila)
Fix Released
Undecided
Valeriy Ponomaryov

Bug Description

When adding a share group type, it must assigned a share type or types. Server should handle specifying the share type by name or ID, but it only handles IDs.

Bug - server should allow the share type to be specified by name.

Changed in manila:
assignee: nobody → Valeriy Ponomaryov (vponomaryov)
status: New → In Progress
Changed in manila:
milestone: none → ocata-rc1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to manila (master)

Fix proposed to branch: master
Review: https://review.openstack.org/426335

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to manila (master)

Reviewed: https://review.openstack.org/426335
Committed: https://git.openstack.org/cgit/openstack/manila/commit/?id=ba5384f8656cf4499bc4f45f915cecfe0cdfcfa3
Submitter: Jenkins
Branch: master

commit ba5384f8656cf4499bc4f45f915cecfe0cdfcfa3
Author: Valeriy Ponomaryov <email address hidden>
Date: Fri Jan 27 19:58:30 2017 +0200

    Fix creation of share group types using share type names

    Before it was possible to create share group types mapping them to
    share types using only share type IDs and when we were providing its
    names we were getting DB error and HTTP 500 as a response.

    Fix it by properly looking for share type by both its unique values -
    ID and name. Also, raise proper 404 error when nothing is found.

    Add functional tests covering this case.

    Change-Id: I216f935383a87f6d679c431bc46cfa8977a6d8ab
    Depends-On: Ic555d241f98d0fa027897c69a7115d1be88f6c96
    Closes-Bug: #1659625

Changed in manila:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/manila 4.0.0.0rc1

This issue was fixed in the openstack/manila 4.0.0.0rc1 release candidate.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.