Driver assisted migration fails to complete because access rules status never goes to 'active'

[Goutham Pacha Ravi]

Steps to reproduce:

* Setup dummy driver
* Start migration with driver assisted options
* Complete migration

Failure in m-shr:

2017-01-20 15:13:42.301 13228 ERROR manila.share.manager [req-b5f28d26-c92c-4194-b3f2-b4cf5b49669d 7cccc87c92664b04b8741b5ab8f951e6 2f3ab114da55476f9a4433c0a8ef10ae - - -] Driver migration completion failed for share c24b78a8-331e-4d50-8507-9f1beedcfe51.
2017-01-20 15:13:42.301 13228 ERROR manila.share.manager Traceback (most recent call last):
2017-01-20 15:13:42.301 13228 ERROR manila.share.manager File "/opt/stack/new/manila/manila/share/manager.py", line 1210, in migration_complete
2017-01-20 15:13:42.301 13228 ERROR manila.share.manager dest_share_instance)
2017-01-20 15:13:42.301 13228 ERROR manila.share.manager File "/opt/stack/new/manila/manila/share/manager.py", line 1153, in _migration_complete_driver
2017-01-20 15:13:42.301 13228 ERROR manila.share.manager helper.apply_new_access_rules(dest_share_instance)
2017-01-20 15:13:42.301 13228 ERROR manila.share.manager File "/opt/stack/new/manila/manila/share/migration.py", line 175, in apply_new_access_rules
2017-01-20 15:13:42.301 13228 ERROR manila.share.manager self.migration_wait_access_rules_timeout)
2017-01-20 15:13:42.301 13228 ERROR manila.share.manager File "/opt/stack/new/manila/manila/utils.py", line 590, in wait_for_access_update
2017-01-20 15:13:42.301 13228 ERROR manila.share.manager raise exception.ShareMigrationFailed(reason=msg)
2017-01-20 15:13:42.301 13228 ERROR manila.share.manager ShareMigrationFailed: Share migration failed: Timeout trying to update access rules on share instance 203a73e7-f232-43e0-97f0-6a672cb81e27. Timeout was 180 seconds.
2017-01-20 15:13:42.301 13228 ERROR manila.share.manager
2017-01-20 15:13:42.424 13228 ERROR oslo_messaging.rpc.server [req-b5f28d26-c92c-4194-b3f2-b4cf5b49669d 7cccc87c92664b04b8741b5ab8f951e6 2f3ab114da55476f9a4433c0a8ef10ae - - -] Exception during message handling
2017-01-20 15:13:42.424 13228 ERROR oslo_messaging.rpc.server Traceback (most recent call last):
2017-01-20 15:13:42.424 13228 ERROR oslo_messaging.rpc.server File "/usr/local/lib/python2.7/dist-packages/oslo_messaging/rpc/server.py", line 155, in _process_incoming
2017-01-20 15:13:42.424 13228 ERROR oslo_messaging.rpc.server res = self.dispatcher.dispatch(message)
2017-01-20 15:13:42.424 13228 ERROR oslo_messaging.rpc.server File "/usr/local/lib/python2.7/dist-packages/oslo_messaging/rpc/dispatcher.py", line 222, in dispatch
2017-01-20 15:13:42.424 13228 ERROR oslo_messaging.rpc.server return self._do_dispatch(endpoint, method, ctxt, args)
2017-01-20 15:13:42.424 13228 ERROR oslo_messaging.rpc.server File "/usr/local/lib/python2.7/dist-packages/oslo_messaging/rpc/dispatcher.py", line 192, in _do_dispatch
2017-01-20 15:13:42.424 13228 ERROR oslo_messaging.rpc.server result = func(ctxt, **new_args)
2017-01-20 15:13:42.424 13228 ERROR oslo_messaging.rpc.server File "/opt/stack/new/manila/manila/utils.py", line 519, in wrapper
2017-01-20 15:13:42.424 13228 ERROR oslo_messaging.rpc.server return func(self, *args, **kwargs)
2017-01-20 15:13:42.424 13228 ERROR oslo_messaging.rpc.server File "/opt/stack/new/manila/manila/share/manager.py", line 1236, in migration_complete
2017-01-20 15:13:42.424 13228 ERROR oslo_messaging.rpc.server raise exception.ShareMigrationFailed(reason=msg)
2017-01-20 15:13:42.424 13228 ERROR oslo_messaging.rpc.server ShareMigrationFailed: Share migration failed: Driver migration completion failed for share c24b78a8-331e-4d50-8507-9f1beedcfe51.
2017-01-20 15:13:42.424 13228 ERROR oslo_messaging.rpc.server

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/423407

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/423407
Committed: https://git.openstack.org/cgit/openstack/manila/commit/?id=6f782959240243d1deebf6dbe4b7e26496257618
Submitter: Jenkins
Branch: master

commit 6f782959240243d1deebf6dbe4b7e26496257618
Author: Ben Swartzlander <email address hidden>
Date: Fri Jan 20 13:38:16 2017 -0500

    Don't call update_access if there are no rules

    This affects access updates in the migration code path.

    Closes bug: 1658157

    Change-Id: I680e0926ab880094b33cf6ac94fb3fb71b8a8dab

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/manila 4.0.0.0b3 development milestone.