export locations tempest tests inadequate

Bug #1655427 reported by Tom Barron
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Shared File Systems Service (Manila)
Fix Released
Medium
Goutham Pacha Ravi

Bug Description

This bug is a placeholder for followup tempest tests to be merged upstream after the fix for https://bugs.launchpad.net/manila/+bug/1654598 is handled. We will use it in the mean time as an anchor for tests that must be skipped because they would break with the fix for 1654598 but their fixes aren't included with it.

Tom Barron (tpb)
Changed in manila:
assignee: nobody → Tom Barron (tpb)
Revision history for this message
Goutham Pacha Ravi (gouthamr) wrote :
Changed in manila:
status: New → Invalid
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to manila-tempest-plugin (master)

Related fix proposed to branch: master
Review: https://review.opendev.org/710660

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Related fix proposed to branch: master
Review: https://review.opendev.org/710661

Changed in manila:
status: Invalid → In Progress
Changed in manila:
assignee: Tom Barron (tpb) → Goutham Pacha Ravi (gouthamr)
Changed in manila:
milestone: none → ussuri-3
importance: Undecided → Medium
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to manila-tempest-plugin (master)

Reviewed: https://review.opendev.org/714181
Committed: https://git.openstack.org/cgit/openstack/manila-tempest-plugin/commit/?id=c678e21b5e0d0aec2d014a40ceadcd573bac08f9
Submitter: Zuul
Branch: master

commit c678e21b5e0d0aec2d014a40ceadcd573bac08f9
Author: Goutham Pacha Ravi <email address hidden>
Date: Fri Mar 20 11:13:47 2020 -0700

    Fix export locations tests

    The tempest tests
    - api.admin.test_export_locations.ExportLocationsTest#test_list_share_export_locations_by_member
    - api.admin.test_export_locations.ExportLocationsTest#test_get_share_export_location_by_member

    were both written with the assumption that a user within a
    project creates a share, and the share's export locations
    are available to other users in the project. In this specific
    context, the user creating the share has an "admin" role -
    but that is just circumstantial. Any user with the ability
    to create shares in a project can do so, and expect that
    those shares are accessible to other users by virtue of default
    policy.

    However, tempest test projects each have only one user,
    and the private share in both these test cases is created
    within the original user's project, and is not supposed to
    be accessible across projects. This behavior is called out in
    LP bug #1654598.

    So, enhance the test infra to create a user within the same
    project applying roles specified within tempest.conf and test
    accessibility with such a user.

    Once bug #1654598 has been resolved, we can use the existing
    test behavior of testing access via a different project as
    negative test cases (See: https://review.opendev.org/710661/)

    Related-Bug: #1654598
    Partial-Bug: #1655427
    Change-Id: I12a1df36e8d928c54c03ed644dd60557f349ddb3
    Signed-off-by: Goutham Pacha Ravi <email address hidden>

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on manila-tempest-plugin (master)

Change abandoned by Tom Barron (<email address hidden>) on branch: master
Review: https://review.opendev.org/710660

Changed in manila:
assignee: Goutham Pacha Ravi (gouthamr) → Tom Barron (tpb)
Changed in manila:
assignee: Tom Barron (tpb) → Goutham Pacha Ravi (gouthamr)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to manila-tempest-plugin (master)

Reviewed: https://review.opendev.org/710661
Committed: https://git.openstack.org/cgit/openstack/manila-tempest-plugin/commit/?id=b5ed5dfaa5ed4989bdefc30abb00902a46052951
Submitter: Zuul
Branch: master

commit b5ed5dfaa5ed4989bdefc30abb00902a46052951
Author: Tom Barron <email address hidden>
Date: Sun Mar 1 21:27:26 2020 +0100

    Fix export location negative tests

    When running as a regular user, attempts to get share export
    locations for a share belonging to another user should be
    forbidden.

    Share instance export locations are not available to regular
    users by virtue of default policy.

    Related-bug: #1654598
    Closes-bug: #1655427
    Change-Id: Iabe7fb68facd0ddffec738ab4e98d1de3a704ee4
    Signed-off-by: Goutham Pacha Ravi <email address hidden>

Changed in manila:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.