GPFS KNFS fails to deny access when access does not exist

[Mark Sturdevant]

When GPFS KNFS driver attempts to deny access to a share the attempt can fail even though the access rule has already been removed. This results in a stuck access rule which can never be removed.

This can happen in a variety of situations due to bugs or partial failures.

When a share deny-access is requested it should not fail when the driver can determine that the access was removed (or does not exist).

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/413762

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/413762
Committed: https://git.openstack.org/cgit/openstack/manila/commit/?id=9157b8afb2177008807156b3f2f776459206ad68
Submitter: Jenkins
Branch: master

commit 9157b8afb2177008807156b3f2f776459206ad68
Author: Mark Sturdevant <email address hidden>
Date: Wed Dec 21 12:00:13 2016 -0800

    GPFS KNFS: Fix deny access to succeed when possible

    Use looser error code checking and add a verify
    after deny access so that the call will succeed
    whenever it can be confirmed that the access no
    longer exists.

    This fixes a variety of situations where previously
    a return code of 1 while attempting to remove access
    would cause the manila access rule to get stuck while
    the actual client access export was removed or never
    existed.

    Change-Id: Ie058a6185e3f5d91fb1cf232301eb0ac6ddcea7e
    Closes-Bug: #1651587

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/manila 4.0.0.0b3 development milestone.