GPFS KNFS multiple ssh prepend with gpfs_nfs_server_list

[Mark Sturdevant]

GPFS KNFS allow/deny access results in incorrect behavior when multiple NFS servers are configured (gpfs_nfs_server_list) and any of the servers are remote (except the last one).

For remote NFS servers with GPFS KNFS, commands are prepended with "ssh <login>@<server>" for remote execution. The prepended information is currently being added to the command in a loop so that in cases where more than one NFS server is configured each following server includes the prefix from the previous one.

This happens to work if the only remote server is the last one. Otherwise the extra ssh prefixes result in the command being forwarded to the wrong server.

For example, a 2nd server may result in a command like "ssh login@server2 ssh login@server1 exportfs..." or a local server may re-use the ssh login@server1 prefix from the remote server earlier in the list.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/413239

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/413239
Committed: https://git.openstack.org/cgit/openstack/manila/commit/?id=b76a2af2370eb55c3a689aecc266baf9364a2750
Submitter: Jenkins
Branch: master

commit b76a2af2370eb55c3a689aecc266baf9364a2750
Author: Mark Sturdevant <email address hidden>
Date: Tue Dec 20 13:29:41 2016 -0800

    GPFS KNFS: Do not reuse ssh prefix in loop

    Fix GPFS KNFS allow/deny access so that it does not reuse
    the ssh prefix when looping through NFS server commands for
    allow and deny access.

    This fixes GPFS KNFS allow/deny access incorrect behavior
    when multiple NFS servers are configured (gpfs_nfs_server_list)
    and any of the servers are remote (except the last one).

    Change-Id: I8c182eed386e8325b087c3192d363502bb848633
    Closes-Bug: #1651578

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/manila 4.0.0.0b3 development milestone.