Cannot setup MANILA_SERVICE_IMAGE_ENABLED in third-party CI

Bug #1649249 reported by Rodrigo Barbieri
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Shared File Systems Service (Manila)
Fix Released
Undecided
Rodrigo Barbieri

Bug Description

According to https://github.com/openstack/manila/blob/9315928347074127faa23186b3fa317dbedc5289/contrib/ci/pre_test_hook.sh#L88 and https://github.com/openstack/manila/blob/9315928347074127faa23186b3fa317dbedc5289/contrib/ci/pre_test_hook.sh#L164 manila CI is overriding and saving MANILA_SERVICE_IMAGE_ENABLED as False regardless of exported variables. This makes it harder for third-party CI to configure this env var value through local.conf or bash export.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to manila (master)

Fix proposed to branch: master
Review: https://review.openstack.org/409733

Changed in manila:
assignee: nobody → Rodrigo Barbieri (rodrigo-barbieri2010)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to manila (master)

Reviewed: https://review.openstack.org/409733
Committed: https://git.openstack.org/cgit/openstack/manila/commit/?id=6168f16c25266326cb953cedf3ed352abe8929e2
Submitter: Jenkins
Branch: master

commit 6168f16c25266326cb953cedf3ed352abe8929e2
Author: Rodrigo Barbieri <email address hidden>
Date: Mon Dec 12 09:14:57 2016 -0200

    Fix Manila service image config for 3rd party CIs

    3rd party CIs cannot set this config by exporting an env var
    or local.conf setting, as it is always being overriden in code.

    Change-Id: Ia2a4790d3a0d03faa231b400c32f6c1928bdca1f
    Closes-bug: #1649249

Changed in manila:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/manila 4.0.0.0b2

This issue was fixed in the openstack/manila 4.0.0.0b2 development milestone.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.