ZFSonLinux share created from snapshot inherits access rules

[Valeriy Ponomaryov]

ZFSonLinux share that was created from snapshot inherits access rules of a parent share. But it should not by design.

Steps to reproduce:
1) create "parent" share
2) add access rule to the "parent" (1) share
3) create snapshot from "parent" (1) share
4) create "child" share from snapshot (3)

Expected result: "child" share does not have access that was added to parent share
Actual result: "child" share does have access that was added to parent share

It can be seen in logs of ZFSonLinux CI job that was reproduced with help of [1], [2] and [3] changes that add/enable scenario tests for this driver.

[1] http://logs.openstack.org/04/402604/3/check/gate-manila-tempest-dsvm-postgres-zfsonlinux-ubuntu-xenial-nv/a956ea7/logs/testr_results.html.gz
[2] https://review.openstack.org/#/c/400758
[3] https://review.openstack.org/#/c/402404
[4] https://review.openstack.org/#/c/402604

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/406904

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/406904
Committed: https://git.openstack.org/cgit/openstack/manila/commit/?id=656dc819061c86ef1b3983279d126d2de4cfefa8
Submitter: Jenkins
Branch: master

commit 656dc819061c86ef1b3983279d126d2de4cfefa8
Author: Valeriy Ponomaryov <email address hidden>
Date: Mon Dec 5 13:45:05 2016 +0200

    [ZFSonLinux] Stop inheriting options creating share from snapshot

    Because, it leads to inheritance of access rules too. That is a bug.
    All other expected options are generated on-fly already.

    Change-Id: Ibe744c9fd001156a8184aa8f955c424cebfb8664
    Closes-Bug: #1645746

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/manila 4.0.0.0b2 development milestone.