Manage/unmanage tempest test leaves shares on backend

[Tiago Pasqualini da Silva]

test_share_manage.ManageNFSShareTest creates the shares and unmanages them on resource_setup. This might cause some shares to not get cleaned up and get left on the backend. In fact, since most CIs only run backend tests, only one test will be run, consequently only one share will be deleted, all other 4 will be left unmanaged on the backend.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/394388
Committed: https://git.openstack.org/cgit/openstack/manila/commit/?id=1eadb5a51cd67610fab9bc5a82b2e6cbd1cbd12c
Submitter: Jenkins
Branch: master

commit 1eadb5a51cd67610fab9bc5a82b2e6cbd1cbd12c
Author: tpsilva <email address hidden>
Date: Mon Nov 7 10:03:39 2016 -0200

    Fix share manage tempest test cleanup

    test_share_manage.ManageNFSShareTest might leave undeleted shares on
    backend if some tests are not run. This happens because the shares are
    created and unmanaged on resource_setup and are expected to be managed
    and deleted on the tests. If the tests don't run, the cleanup will not
    delete the shares because they are already unmanaged, thus leaving them
    created on the backend.

    This patch fixes this issue by moving the share creation and unmanage
    operations from resource_setup to the tests themselves.

    Closes-bug: #1639848

    Change-Id: I2d1790f0a323fdc7b11805842985ca5907dd23c3

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/manila 4.0.0.0b1 development milestone.