Compare encoded configuration more accurately for huawei driver
Bug #1635073 reported by
Yingzhe Zeng
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
OpenStack Shared File Systems Service (Manila) |
Fix Released
|
Undecided
|
Yingzhe Zeng |
Bug Description
huawei driver uses a tag '!$$$' to indicate if username/password
is encoded or not in huawei configuration file.
Currently 'find' method is used to check if this tag is included
in the configuration string, but it'll misread if the tag is
included not in front of the string.
Changed in manila: | |
assignee: | nobody → Yingzhe Zeng (zengyingzhe) |
summary: |
- Compare encoded configuration more accurately + Compare encoded configuration more accurately for huawei driver |
Changed in manila: | |
status: | New → In Progress |
To post a comment you must log in.
Reviewed: https:/ /review. openstack. org/388473 /git.openstack. org/cgit/ openstack/ manila/ commit/ ?id=3f2800ede54 692510c4c652c34 176aa6c10c7f97
Committed: https:/
Submitter: Jenkins
Branch: master
commit 3f2800ede546925 10c4c652c34176a a6c10c7f97
Author: zengyingzhe <email address hidden>
Date: Wed Oct 19 14:58:40 2016 +0800
Compare the encoded tag more accurately for huawei driver
huawei driver uses a tag '!$$$' to indicate if username/password
is encoded or not in huawei configuration file.
Currently 'find' method is used to check if this tag is included
in the configuration string, but it'll misread if the tag is
included not in front of the string.
So change the comparing statement to a more accurate way, compare
the front slice of the string directly to the tag.
Change-Id: Ic3439705784773 62460340b01e576 6e03c7d63a4
Closes-Bug: 1635073