Compare encoded configuration more accurately for huawei driver

Bug #1635073 reported by Yingzhe Zeng
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Shared File Systems Service (Manila)
Fix Released
Undecided
Yingzhe Zeng

Bug Description

huawei driver uses a tag '!$$$' to indicate if username/password
is encoded or not in huawei configuration file.

Currently 'find' method is used to check if this tag is included
in the configuration string, but it'll misread if the tag is
included not in front of the string.

Changed in manila:
assignee: nobody → Yingzhe Zeng (zengyingzhe)
summary: - Compare encoded configuration more accurately
+ Compare encoded configuration more accurately for huawei driver
Changed in manila:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to manila (master)

Reviewed: https://review.openstack.org/388473
Committed: https://git.openstack.org/cgit/openstack/manila/commit/?id=3f2800ede54692510c4c652c34176aa6c10c7f97
Submitter: Jenkins
Branch: master

commit 3f2800ede54692510c4c652c34176aa6c10c7f97
Author: zengyingzhe <email address hidden>
Date: Wed Oct 19 14:58:40 2016 +0800

    Compare the encoded tag more accurately for huawei driver

    huawei driver uses a tag '!$$$' to indicate if username/password
    is encoded or not in huawei configuration file.

    Currently 'find' method is used to check if this tag is included
    in the configuration string, but it'll misread if the tag is
    included not in front of the string.

    So change the comparing statement to a more accurate way, compare
    the front slice of the string directly to the tag.

    Change-Id: Ic343970578477362460340b01e5766e03c7d63a4
    Closes-Bug: 1635073

Changed in manila:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/manila 4.0.0.0b1

This issue was fixed in the openstack/manila 4.0.0.0b1 development milestone.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.