create replica failed if share_backend_name is specified in share type

Bug #1634734 reported by Yingzhe Zeng on 2016-10-19
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Manila
Medium
Goutham Pacha Ravi

Bug Description

If a share is created based on a share type, in which the share_backend_name
is specified as an extra spec, then try to create a replica for this share,
it'll fail due to scheduler cannot get a available backend for replica
creation, because scheduler only can use the backend that share_backend_name
specified, but the backend already has the active replica, according to the
replication design, no more than 1 replicas can exist in the same backend,
so scheduler cannot find a available backend, this operation will fail.

Fix proposed to branch: master
Review: https://review.openstack.org/391353

Changed in manila:
assignee: nobody → Yingzhe Zeng (zengyingzhe)
status: New → In Progress

Change abandoned by Tom Barron (<email address hidden>) on branch: master
Review: https://review.openstack.org/391353
Reason: No activity since November 2016; restore and rebase if still relevant.

Jason Grosso (jgrosso) wrote :

please re-open this issue if it still relevant.

Changed in manila:
status: In Progress → Won't Fix
Changed in manila:
assignee: Yingzhe Zeng (zengyingzhe) → Goutham Pacha Ravi (gouthamr)
status: Won't Fix → In Progress
Changed in manila:
milestone: none → train-3
importance: Undecided → Medium
tags: added: stein-backport-potential
tags: added: queens-backport-potential rocky-backport-potential
tags: added: replication share
Jason Grosso (jgrosso) wrote :

Thank Goutham

Changed in manila:
milestone: train-3 → train-rc1
tags: added: train-rc1-potential

Reviewed: https://review.opendev.org/391353
Committed: https://git.openstack.org/cgit/openstack/manila/commit/?id=700c1a02f0a357312df8f47932f83e86a3d2dc86
Submitter: Zuul
Branch: master

commit 700c1a02f0a357312df8f47932f83e86a3d2dc86
Author: zengyingzhe <email address hidden>
Date: Fri Oct 28 15:26:22 2016 +0800

    Remove backend spec from share type while creating replica

    If a share type includes the share_backend_name spec,
    the scheduler may fail to schedule share replicas unless
    all backends in a replication domain share the same
    value for the capability "share_backend_name". Having
    the same "share_backend_name" isn't desirable all the
    time.

    Ignore the share_backend_name spec from share type
    while creating replica, so the scheduler will filter
    a available backend according to the selection policy.

    Change-Id: Ic8f7e6230298c222cc6cb5e4e4e8189524aaa81f
    Closes-Bug: #1634734

Changed in manila:
status: In Progress → Fix Released

Reviewed: https://review.opendev.org/687688
Committed: https://git.openstack.org/cgit/openstack/manila/commit/?id=19c4869a3f004e4ec699412c1831765b714aa93b
Submitter: Zuul
Branch: stable/train

commit 19c4869a3f004e4ec699412c1831765b714aa93b
Author: zengyingzhe <email address hidden>
Date: Fri Oct 28 15:26:22 2016 +0800

    Remove backend spec from share type while creating replica

    If a share type includes the share_backend_name spec,
    the scheduler may fail to schedule share replicas unless
    all backends in a replication domain share the same
    value for the capability "share_backend_name". Having
    the same "share_backend_name" isn't desirable all the
    time.

    Ignore the share_backend_name spec from share type
    while creating replica, so the scheduler will filter
    a available backend according to the selection policy.

    Change-Id: Ic8f7e6230298c222cc6cb5e4e4e8189524aaa81f
    Closes-Bug: #1634734
    (cherry picked from commit 700c1a02f0a357312df8f47932f83e86a3d2dc86)

tags: added: in-stable-train

Reviewed: https://review.opendev.org/688171
Committed: https://git.openstack.org/cgit/openstack/manila/commit/?id=e2fe03e25363a35bd07895505c18d349e4a330e7
Submitter: Zuul
Branch: stable/stein

commit e2fe03e25363a35bd07895505c18d349e4a330e7
Author: zengyingzhe <email address hidden>
Date: Fri Oct 28 15:26:22 2016 +0800

    Remove backend spec from share type while creating replica

    If a share type includes the share_backend_name spec,
    the scheduler may fail to schedule share replicas unless
    all backends in a replication domain share the same
    value for the capability "share_backend_name". Having
    the same "share_backend_name" isn't desirable all the
    time.

    Ignore the share_backend_name spec from share type
    while creating replica, so the scheduler will filter
    a available backend according to the selection policy.

    Change-Id: Ic8f7e6230298c222cc6cb5e4e4e8189524aaa81f
    Closes-Bug: #1634734
    (cherry picked from commit 700c1a02f0a357312df8f47932f83e86a3d2dc86)
    (cherry picked from commit 19c4869a3f004e4ec699412c1831765b714aa93b)

tags: added: in-stable-stein

Reviewed: https://review.opendev.org/688314
Committed: https://git.openstack.org/cgit/openstack/manila/commit/?id=bffeef11b4aea4a9e718fb7814336149b1d2abfd
Submitter: Zuul
Branch: stable/rocky

commit bffeef11b4aea4a9e718fb7814336149b1d2abfd
Author: zengyingzhe <email address hidden>
Date: Fri Oct 28 15:26:22 2016 +0800

    Remove backend spec from share type while creating replica

    If a share type includes the share_backend_name spec,
    the scheduler may fail to schedule share replicas unless
    all backends in a replication domain share the same
    value for the capability "share_backend_name". Having
    the same "share_backend_name" isn't desirable all the
    time.

    Ignore the share_backend_name spec from share type
    while creating replica, so the scheduler will filter
    a available backend according to the selection policy.

    Change-Id: Ic8f7e6230298c222cc6cb5e4e4e8189524aaa81f
    Closes-Bug: #1634734
    (cherry picked from commit 700c1a02f0a357312df8f47932f83e86a3d2dc86)
    (cherry picked from commit 19c4869a3f004e4ec699412c1831765b714aa93b)
    (cherry picked from commit e2fe03e25363a35bd07895505c18d349e4a330e7)

tags: added: in-stable-rocky

Reviewed: https://review.opendev.org/688313
Committed: https://git.openstack.org/cgit/openstack/manila/commit/?id=c761bb559e9a79659ed5c4a6bfb79e30c5ecdc90
Submitter: Zuul
Branch: stable/queens

commit c761bb559e9a79659ed5c4a6bfb79e30c5ecdc90
Author: zengyingzhe <email address hidden>
Date: Fri Oct 28 15:26:22 2016 +0800

    Remove backend spec from share type while creating replica

    If a share type includes the share_backend_name spec,
    the scheduler may fail to schedule share replicas unless
    all backends in a replication domain share the same
    value for the capability "share_backend_name". Having
    the same "share_backend_name" isn't desirable all the
    time.

    Ignore the share_backend_name spec from share type
    while creating replica, so the scheduler will filter
    a available backend according to the selection policy.

    Change-Id: Ic8f7e6230298c222cc6cb5e4e4e8189524aaa81f
    Closes-Bug: #1634734
    (cherry picked from commit 700c1a02f0a357312df8f47932f83e86a3d2dc86)
    (cherry picked from commit 19c4869a3f004e4ec699412c1831765b714aa93b)
    (cherry picked from commit e2fe03e25363a35bd07895505c18d349e4a330e7)
    (cherry picked from commit bffeef11b4aea4a9e718fb7814336149b1d2abfd)

tags: added: in-stable-queens

This issue was fixed in the openstack/manila 6.3.2 release.

This issue was fixed in the openstack/manila 9.1.0 release.

This issue was fixed in the openstack/manila 8.1.0 release.

This issue was fixed in the openstack/manila 7.4.0 release.

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers