Container driver fails to release share server on ubuntu-xenial

[Valeriy Ponomaryov]

http://logs.openstack.org/12/379412/4/check/gate-manila-tempest-dsvm-postgres-container-ubuntu-xenial-nv/6919034/logs/screen-m-shr.txt.gz?level=TRACE#_2016-09-29_15_08_56_980

How to reproduce:
1) Create share
2) Delete share
3) Delete share server using "share-server-delete" shell command

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/383675

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/383675
Committed: https://git.openstack.org/cgit/openstack/manila/commit/?id=8401c150f3488b3445496cd0807207b9171f61cb
Submitter: Jenkins
Branch: master

commit 8401c150f3488b3445496cd0807207b9171f61cb
Author: Valeriy Ponomaryov <email address hidden>
Date: Fri Oct 7 14:27:43 2016 +0300

    [Container] Fix deletion of veths

    In '_teardown_server' method driver was searching for all matches of
    'veth' prefix and looping them for deletion. But using Xenial host
    it finds each such veth name twice and tries to delete the same veth
    twice too getting following error:

    ovs-vsctl: no row "veth7ac5738" in table Interface

    So, fix it by translating 'list' of veths to 'set' that
    will have only unique names.

    Change-Id: I819a885547f9fc595b15f98e4c94de21e33914ac
    Closes-Bug: #1630512

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/384606

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/384606
Committed: https://git.openstack.org/cgit/openstack/manila/commit/?id=5a77f193286367ebed0dd9af6bcd4334b314f287
Submitter: Jenkins
Branch: stable/newton

commit 5a77f193286367ebed0dd9af6bcd4334b314f287
Author: Valeriy Ponomaryov <email address hidden>
Date: Fri Oct 7 14:27:43 2016 +0300

    [Container] Fix deletion of veths

    In '_teardown_server' method driver was searching for all matches of
    'veth' prefix and looping them for deletion. But using Xenial host
    it finds each such veth name twice and tries to delete the same veth
    twice too getting following error:

    ovs-vsctl: no row "veth7ac5738" in table Interface

    So, fix it by translating 'list' of veths to 'set' that
    will have only unique names.

    Change-Id: I819a885547f9fc595b15f98e4c94de21e33914ac
    Closes-Bug: #1630512
    (cherry picked from commit 8401c150f3488b3445496cd0807207b9171f61cb)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/manila 4.0.0.0b1 development milestone.