NetApp cDOT driver does not eliminate untenable pools

[Goutham Pacha Ravi]

When using the NetApp cDOT driver:
* netapp_aggregate_name_search_pattern is used to identify pools (cDOT aggregates) for provisioning.

* In the DHSS=True mode, these "pools" are assigned to share servers (cDOT vServers) upon share server creation and reported to the scheduler.
* In the DHSS=False mode, these "pools" are read and reported to the scheduler for the given vServer.

cDOT does not allow provisioning of new manila shares on root aggregates. The driver should remove these aggregates from consideration.

--Steps to reproduce--

**DHSS=False**
# Assign a root aggregate as a vserver aggregate

**Both modes**
# make sure netapp_aggregate_name_search_pattern encompasses the name of this aggregate.
# create a share within that aggregate (you could use 'pool_name' as your extra-spec)

[Goutham Pacha Ravi (gouthamr)]

When we have the right cluster permissions, it is possible to eliminate these aggregates. Worthwhile fix.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/385594

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/385594
Committed: https://git.openstack.org/cgit/openstack/manila/commit/?id=eb2d9640e2b09553c70a4726c1e3a0e5fa4db025
Submitter: Jenkins
Branch: master

commit eb2d9640e2b09553c70a4726c1e3a0e5fa4db025
Author: Clinton Knight <email address hidden>
Date: Thu Sep 29 19:39:36 2016 -0400

    NetApp cDOT driver should not report untenable pools

    The NetApp cDOT driver now explicitly filters root aggregates
    from the pools reported to the manila scheduler if the driver
    is operating with cluster credentials.

    Change-Id: I659edada559e50d2332790025c65fae265a27c3d
    Closes-Bug: #1624526

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/manila 4.0.0.0b1 development milestone.