allow/deny do not show proper message when share is migrating

[Rodrigo Barbieri]

If a share is migrating and phase 1 is completed, upon attempting to add an access rule, the message shown is

"Share status must be available, or migrating while first phase of migration is completed."

Although it implies that access would be granted in that case, as discussed on IRC, it should not grant access for shares that are migrating.

[Goutham Pacha Ravi (gouthamr)]

Fix proposed to branch: master
Review: https://review.openstack.org/#/c/365136

Changed in manila:
assignee: nobody → Rodrigo Barbieri (rodrigo-barbieri2010)
status: New → In Progress

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/365136
Committed: https://git.openstack.org/cgit/openstack/manila/commit/?id=10487a14a3673d4a28a4ea85a62619e69d5c669b
Submitter: Jenkins
Branch: master

commit 10487a14a3673d4a28a4ea85a62619e69d5c669b
Author: Rodrigo Barbieri <email address hidden>
Date: Mon Sep 12 16:22:34 2016 -0300

    Fix allow/deny error message and race in migration

    Share migration code [1] merged in newton intending to allow admins
    to mount the share between phase1 and phase2, but API code for
    allow_access and deny_access was set incorrectly, blocking it.

    After discussing this feature's purpose further, we decided we do
    not want this feature at this moment, so we are just fixing the
    allow_access and deny_access error messages.

    Also, addressed a small case of concurrency that was happening
    once in a while in CI. Update_access was being invoked while
    other rules were being applied, thus setting the access_rule_state
    to "UPDATING_MULTIPLE", ignoring the migration access rule change
    RPC request completely, failing migration. By refreshing the
    model we are able to assign the proper access_rule_state at the
    time the function is invoked, setting the access_rule_state
    correctly.

    [1] If4bfaf7e9d963b83c13a6fea241c2eda14f7f409

    APIImpact

    Closes-bug: #1623051
    Closes-bug: #1623052

    Change-Id: I76a7d8c3bdd597b951e700350f8f3f82bfb21e03

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/manila 3.0.0.0rc1 release candidate.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/manila 3.0.0 release.