Manila HSP driver doesnt support adding existent rules after manage

[Alyson]

HSP Driver fails when trying to add a rule that already exists in backend for a managed share. It returns "Duplicate NFS rules" and change the rule to an ERROR state.
Also, deleting this existent rules created outside Manila would fail too, since deny operation send "share_id + ip" as rule name and it can be not the name provided by the user.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/366310

[Rodrigo Barbieri (rodrigo-barbieri2010)]

Talking to Alyson, this bug does not have a workaround, so changed it to High priority. Also, it leads to another bug where any previously existing rules in HSP cannot be removed through manila, hence the share cannot be deleted, stating that the "Object still has children". So, when deleting a share, it should have its previously existing rules removed as well to properly fix this bug.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/366310
Committed: https://git.openstack.org/cgit/openstack/manila/commit/?id=b29a0e553f44266fbc544f5cb95cf89f6cfd39db
Submitter: Jenkins
Branch: master

commit b29a0e553f44266fbc544f5cb95cf89f6cfd39db
Author: Alyson Rosa <email address hidden>
Date: Tue Sep 6 16:00:29 2016 -0300

    Fix access rules for managed shares in HSP driver

    A share managed in HSP could have some access rules that
    are not in Manila. Trying to add a rule that already exists
    in backend results in an error. Also, rules in backend that
    names are not "share_id + ip" can't be deleted.
    Additionally, if this share has a rule only in backend and not in
    Manila, trying to delete it would fail, because HSP doesn't allow
    delete share when it still has rules.

    Fix it by adding a check in update access when rules already
    exist in backend. Check for access rule name in backend when
    denying access. And cleaning all rules from backend before
    deleting a share to ensure that it has no children in HSP.

    Change-Id: I0c8ee5c47efe22f004692022dd952f301d669b06
    Closes-Bug: #1620756

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/manila 3.0.0.0rc1 release candidate.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/manila 3.0.0 release.