Share migration does not allow_access before migration_complete

[Rodrigo Barbieri]

Commit [1] intended to add the possibility of admin mounting the source and destination shares to check the data before issuing migration-complete, but currently it is not allowing so.

Steps to reproduce:

1) create a share
2) invoke "migration-start" of the share to another backend
3) wait for status "data_copying_completed" or "migration_driver_phase1_done"
4) try to add an access rule such as "manila access-allow share_x ip 10.0.0.5"
5) observe that it says "Share status must be 'available'".

[1] https://github.com/openstack/manila/commit/c7fe51e79b63f3e0556cce19a48252aaee317823

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/365136

[Goutham Pacha Ravi (gouthamr)]

As discussed on IRC, there is very little value in holding this expectation of driver-assisted migration implementations. We may discuss this as a feature enhancement in Ocata if there is really a desire to mount the destination when migration has completed phase 1 (the data copy phase).