Race condition in generic drivers updating routes

Bug #1617461 reported by Rodrigo Barbieri
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Shared File Systems Service (Manila)
Fix Released
Medium
Rodrigo Barbieri

Bug Description

Generic driver updates routes on host according to the tap interfaces created for use by share servers. That code should be within a lock to prevent a thread failing to delete a route previously listed and already deleted by another thread.

See https://github.com/openstack/manila/blob/06eabef61d2482dd81c0f361ceb89883714c346b/manila/share/drivers/service_instance.py#L951

Changed in manila:
assignee: nobody → Rodrigo Barbieri (rodrigo-barbieri2010)
status: New → In Progress
Changed in manila:
milestone: none → newton-rc1
importance: Undecided → High
importance: High → Medium
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to manila (master)

Reviewed: https://review.openstack.org/361473
Committed: https://git.openstack.org/cgit/openstack/manila/commit/?id=3e96712c47dd490a43216069033927ff1c73feb5
Submitter: Jenkins
Branch: master

commit 3e96712c47dd490a43216069033927ff1c73feb5
Author: Rodrigo Barbieri <email address hidden>
Date: Fri Aug 26 18:13:00 2016 -0300

    Fix race condition updating routes

    Generic driver updates routes on host according to the tap
    interfaces created for use by share servers. That code
    should be within a lock to prevent a thread failing to delete
    a route previously listed and already deleted by another thread.

    This change moves an existing lock to the function that
    performs route changes while also covering the function
    that had the lock before.

    Closes-bug: #1617461

    Change-Id: I798e5d9b0bc9ebefc8661d0ade720c60303cf484

Changed in manila:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/manila 3.0.0.0rc1

This issue was fixed in the openstack/manila 3.0.0.0rc1 release candidate.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/manila 3.0.0

This issue was fixed in the openstack/manila 3.0.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.