[api] manila API returns HTTP 404 NotFound even when the resource that it raised the error for is not part of the URI

Bug #1607422 reported by Goutham Pacha Ravi
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Shared File Systems Service (Manila)
Won't Fix
Wishlist
Unassigned

Bug Description

HTTP404 should only be returned when the resource that is missing/unknown is part of the URI. If the resource that is missing is part of the request body, HTTPBadRequest is the right response code to return.

Tags: api
Changed in manila:
importance: Undecided → Medium
tags: added: api
Changed in manila:
assignee: nobody → NidhiMittalHada (nidhimittal19)
Tom Barron (tpb)
Changed in manila:
assignee: NidhiMittalHada (nidhimittal19) → nobody
Revision history for this message
Jason Grosso (jgrosso) wrote :

Are there plans to work on this bug?

Revision history for this message
Jason Grosso (jgrosso) wrote :
Revision history for this message
Goutham Pacha Ravi (gouthamr) wrote :

Hi Jason,

No, this isn't related to https://bugs.launchpad.net/manila/+bug/1567387.
but, is quite related to https://bugs.launchpad.net/manila/+bug/1607405

We have many APIs that return 404 even when the requested resource is not in the URL. Maybe it helps if I clarify which specific API's return status 404 instead of 400. The API ref does a good job of capturing this information: https://developer.openstack.org/api-ref/shared-file-system/

This bug should be a wishlist improvement at best, since the API has been published for many releases, and tooling has been built around it. It seems too small a gain to go fix past mistakes to adhere to HTTP standards. We can accept that our APIs are not perfect, and ensure (as we've been doing since OpenStack has had an API-SIG, and we nominated a liaison for it) that we don't repeat these mistakes.

Thanks for reminding me to update this bug. I'm now marking it "Won't fix" - "Wishlist".

Changed in manila:
status: New → Won't Fix
importance: Medium → Wishlist
Revision history for this message
Jason Grosso (jgrosso) wrote :

thanks for the update Goutham

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.