lvm config options are missing from sample config

Bug #1599119 reported by Tom Barron
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Shared File Systems Service (Manila)
Fix Released
Undecided
Tom Barron

Bug Description

tbarron@ganges manila (master)$ tox -egenconfig
genconfig develop-inst-nodeps: /home/tbarron/Workspaces/manila
genconfig installed: alembic==0.8.6,amqp==1.4.9,anyjson==0.3.3,appdirs==1.4.0,Babel==2.3.4,bashate==0.5.1,cachetools==1.1.6,cffi==1.7.0,cliff==2.1.0,cmd2==0.6.8,contextlib2==0.5.3,coverage==4.1,cryptography==1.4,ddt==1.1.0,debtcollector==1.5.0,decorator==4.0.10,docutils==0.12,enum34==1.1.6,eventlet==0.19.0,extras==1.0.0,fasteners==0.14.1,fixtures==3.0.0,flake8==2.2.4,funcsigs==1.0.2,futures==3.0.5,futurist==0.14.0,greenlet==0.4.10,hacking==0.10.2,idna==2.1,ipaddress==1.0.16,iso8601==0.1.11,Jinja2==2.8,keystoneauth1==2.8.0,keystonemiddleware==4.5.1,kombu==3.0.35,linecache2==1.0.0,lxml==3.6.0,Mako==1.0.4,-e git+https://review.openstack.org/p/openstack/manila@5b11b87dc732056170861f0e64e044cd7f08e172#egg=manila,MarkupSafe==0.23,mccabe==0.2.1,mock==2.0.0,monotonic==1.1,mox3==0.16.0,msgpack-python==0.4.7,netaddr==0.7.18,netifaces==0.10.4,openstackdocstheme==1.3.0,os-client-config==1.18.0,os-testr==0.7.0,oslo.concurrency==3.11.0,oslo.config==3.12.0,oslo.context==2.5.0,oslo.db==4.7.0,oslo.i18n==3.7.0,oslo.log==3.11.0,oslo.messaging==5.5.0,oslo.middleware==3.14.0,oslo.policy==1.11.0,oslo.rootwrap==4.3.0,oslo.serialization==2.10.0,oslo.service==1.12.0,oslo.utils==3.14.0,oslosphinx==4.5.0,oslotest==2.6.0,paramiko==2.0.1,Paste==2.0.3,PasteDeploy==1.5.2,pbr==1.10.0,pep8==1.5.7,pika==0.10.0,pika-pool==0.1.3,positional==1.1.1,prettytable==0.7.2,psycopg2==2.6.1,pyasn1==0.1.9,pycadf==2.3.0,pycparser==2.14,pyflakes==0.8.1,Pygments==2.1.3,pyinotify==0.9.6,PyMySQL==0.7.5,pyparsing==2.1.5,python-cinderclient==1.8.0,python-dateutil==2.5.3,python-editor==1.0.1,python-keystoneclient==3.1.0,python-mimeparse==1.5.2,python-neutronclient==4.2.0,python-novaclient==4.1.0,python-subunit==1.2.0,pytz==2016.4,PyYAML==3.11,reno==1.8.0,repoze.lru==0.6,requests==2.10.0,requests-mock==1.0.0,requestsexceptions==1.1.3,retrying==1.3.3,rfc3986==0.3.1,Routes==2.3.1,simplejson==3.8.2,six==1.10.0,Sphinx==1.2.3,SQLAlchemy==1.0.13,sqlalchemy-migrate==0.10.0,sqlparse==0.1.19,stevedore==1.15.0,Tempita==0.5.2,testrepository==0.0.20,testresources==2.0.1,testscenarios==0.5.0,testtools==2.2.0,traceback2==1.4.0,unicodecsv==0.14.1,unittest2==1.1.0,WebOb==1.6.1,wrapt==1.10.8
genconfig runtests: PYTHONHASHSEED='876564636'
genconfig runtests: commands[0] | oslo-config-generator --config-file etc/oslo-config-generator/manila.conf
_________________________________________________________ summary _________________________________________________________
  genconfig: commands succeeded
  congratulations :)
tbarron@ganges manila (master)$ grep lvm etc/manila/manila.conf.sample
tbarron@ganges manila (master)$

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to manila (master)

Fix proposed to branch: master
Review: https://review.openstack.org/337609

Changed in manila:
assignee: nobody → Tom Barron (tpb)
status: New → In Progress
Revision history for this message
Tom Barron (tpb) wrote :

With the fix:

tbarron@ganges manila (config-fix)$ tox -egenconfig
genconfig develop-inst-nodeps: /home/tbarron/Workspaces/manila
genconfig installed: alembic==0.8.6,amqp==1.4.9,anyjson==0.3.3,appdirs==1.4.0,Babel==2.3.4,bashate==0.5.1,cachetools==1.1.6,cffi==1.7.0,cliff==2.1.0,cmd2==0.6.8,contextlib2==0.5.3,coverage==4.1,cryptography==1.4,ddt==1.1.0,debtcollector==1.5.0,decorator==4.0.10,docutils==0.12,enum34==1.1.6,eventlet==0.19.0,extras==1.0.0,fasteners==0.14.1,fixtures==3.0.0,flake8==2.2.4,funcsigs==1.0.2,futures==3.0.5,futurist==0.14.0,greenlet==0.4.10,hacking==0.10.2,idna==2.1,ipaddress==1.0.16,iso8601==0.1.11,Jinja2==2.8,keystoneauth1==2.8.0,keystonemiddleware==4.5.1,kombu==3.0.35,linecache2==1.0.0,lxml==3.6.0,Mako==1.0.4,-e git+https://review.openstack.org/p/openstack/manila@5b11b87dc732056170861f0e64e044cd7f08e172#egg=manila,MarkupSafe==0.23,mccabe==0.2.1,mock==2.0.0,monotonic==1.1,mox3==0.16.0,msgpack-python==0.4.7,netaddr==0.7.18,netifaces==0.10.4,openstackdocstheme==1.3.0,os-client-config==1.18.0,os-testr==0.7.0,oslo.concurrency==3.11.0,oslo.config==3.12.0,oslo.context==2.5.0,oslo.db==4.7.0,oslo.i18n==3.7.0,oslo.log==3.11.0,oslo.messaging==5.5.0,oslo.middleware==3.14.0,oslo.policy==1.11.0,oslo.rootwrap==4.3.0,oslo.serialization==2.10.0,oslo.service==1.12.0,oslo.utils==3.14.0,oslosphinx==4.5.0,oslotest==2.6.0,paramiko==2.0.1,Paste==2.0.3,PasteDeploy==1.5.2,pbr==1.10.0,pep8==1.5.7,pika==0.10.0,pika-pool==0.1.3,positional==1.1.1,prettytable==0.7.2,psycopg2==2.6.1,pyasn1==0.1.9,pycadf==2.3.0,pycparser==2.14,pyflakes==0.8.1,Pygments==2.1.3,pyinotify==0.9.6,PyMySQL==0.7.5,pyparsing==2.1.5,python-cinderclient==1.8.0,python-dateutil==2.5.3,python-editor==1.0.1,python-keystoneclient==3.1.0,python-mimeparse==1.5.2,python-neutronclient==4.2.0,python-novaclient==4.1.0,python-subunit==1.2.0,pytz==2016.4,PyYAML==3.11,reno==1.8.0,repoze.lru==0.6,requests==2.10.0,requests-mock==1.0.0,requestsexceptions==1.1.3,retrying==1.3.3,rfc3986==0.3.1,Routes==2.3.1,simplejson==3.8.2,six==1.10.0,Sphinx==1.2.3,SQLAlchemy==1.0.13,sqlalchemy-migrate==0.10.0,sqlparse==0.1.19,stevedore==1.15.0,Tempita==0.5.2,testrepository==0.0.20,testresources==2.0.1,testscenarios==0.5.0,testtools==2.2.0,traceback2==1.4.0,unicodecsv==0.14.1,unittest2==1.1.0,WebOb==1.6.1,wrapt==1.10.8
genconfig runtests: PYTHONHASHSEED='3415139415'
genconfig runtests: commands[0] | oslo-config-generator --config-file etc/oslo-config-generator/manila.conf
_________________________________________________________ summary _________________________________________________________
  genconfig: commands succeeded
  congratulations :)
tbarron@ganges manila (config-fix)$ grep lvm etc/manila/manila.conf.sample
#lvm_share_export_root = $state_path/mnt
#lvm_share_export_ip = <None>
# lvm_mirrors + 2 PVs with available space. (integer value)
#lvm_share_mirrors = 0
#lvm_share_volume_group = lvm-shares
#lvm_share_helpers = CIFS=manila.share.drivers.helpers.CIFSHelperUserAccess,NFS=manila.share.drivers.helpers.NFSHelper
tbarron@ganges manila (config-fix)$

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to manila (master)

Reviewed: https://review.openstack.org/337609
Committed: https://git.openstack.org/cgit/openstack/manila/commit/?id=2d6d4c61e893359ca17974b4d67d346d78fb9452
Submitter: Jenkins
Branch: master

commit 2d6d4c61e893359ca17974b4d67d346d78fb9452
Author: Tom Barron <email address hidden>
Date: Tue Jul 5 06:58:24 2016 -0400

    Add lvm driver options to sample config

    Closes-Bug: #1599119

    Change-Id: Idda0f83b900fe338de352f146fa2fe6cda2308dd

Changed in manila:
status: In Progress → Fix Released
Revision history for this message
Doug Hellmann (doug-hellmann) wrote : Fix included in openstack/manila 3.0.0.0b2

This issue was fixed in the openstack/manila 3.0.0.0b2 development milestone.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.