use assertTrue rather than assertEqual(True in tests

Bug #1584948 reported by Tom Barron
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Shared File Systems Service (Manila)
Fix Released
Undecided
Tom Barron

Bug Description

manila unit tests contain several uses of assertEqual(True, ...) instead of assertTrue(...).

Need to fix these and add a hacking check so more instances of this issue don't creep in.

Tags: tests
Tom Barron (tpb)
Changed in manila:
assignee: nobody → Tom Barron (tpb)
tags: added: tests
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to manila (master)

Fix proposed to branch: master
Review: https://review.openstack.org/320141

Changed in manila:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to manila (master)

Reviewed: https://review.openstack.org/320141
Committed: https://git.openstack.org/cgit/openstack/manila/commit/?id=b85248bce686309395e92f8b7e31f8a4e8fe7fd4
Submitter: Jenkins
Branch: master

commit b85248bce686309395e92f8b7e31f8a4e8fe7fd4
Author: Tom Barron <email address hidden>
Date: Mon May 23 16:35:56 2016 -0400

    Use assertTrue rather than assertEqual(True, ...)

    Manila unit tests contain several occurences of
    assertEqual(True, ...) instead of assertTrue(...).

    Fix these occurences and add hacking check so new
    occurences don't creep into the codebase.

    Closes-Bug: #1584948

    Change-Id: Ib586590b9efcb5253e8c09ee735a8ffb62b44d74

Changed in manila:
status: In Progress → Fix Released
Revision history for this message
Thierry Carrez (ttx) wrote : Fix included in openstack/manila 3.0.0.0b1

This issue was fixed in the openstack/manila 3.0.0.0b1 development milestone.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.