OpenStack Shared File Systems Service (Manila)

manila_tempest_test does not cleanup appropriately while retrying

Bug #1577887 reported by Goutham Pacha Ravi on 2016-05-03

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	OpenStack Shared File Systems Service (Manila)	Fix Released	Medium	Valeriy Ponomaryov	OpenStack Shared File Systems Service (Manila) newton-2 "N2"

Bug Description

Noticed a gate failure on the NetApp CI recently that had this behavior,

When retrying to create shares that failed (for any reason), cleanup is not being done for the share in 'error' state immediately. This does not bode well for the Consistency Groups feature where, to take a CG snapshot, all shares in the CG must have their status set to 'available'.

tempest LOG attached.

Tags:

Revision history for this message

Goutham Pacha Ravi (gouthamr) wrote on 2016-05-03:

Tempest log Edit (76.4 KiB, text/plain)

NidhiMittalHada (nidhimittal19) on 2016-05-11

Changed in manila:
assignee:	nobody → NidhiMittalHada (nidhimittal19)

Ben Swartzlander (bswartz) on 2016-06-07

Changed in manila:
importance:	Undecided → Critical
assignee:	NidhiMittalHada (nidhimittal19) → nobody

Valeriy Ponomaryov (vponomaryov) on 2016-06-08

Changed in manila:
assignee:	nobody → Valeriy Ponomaryov (vponomaryov)
status:	New → In Progress
milestone:	none → newton-3
milestone:	newton-3 → newton-2

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-06-08: Fix proposed to manila (master)

Fix proposed to branch: master
Review: https://review.openstack.org/327059

Revision history for this message

Valeriy Ponomaryov (vponomaryov) wrote on 2016-07-08:

No activity on proposed fix for a month. Setting "medium".

Changed in manila:
importance:	Critical → Medium

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-07-13: Fix merged to manila (master)

Reviewed: https://review.openstack.org/327059
Committed: https://git.openstack.org/cgit/openstack/manila/commit/?id=bb01fe9314f990accfbb1ea11c2a63b4fab1c27f
Submitter: Jenkins
Branch: master

commit bb01fe9314f990accfbb1ea11c2a63b4fab1c27f
Author: Valeriy Ponomaryov <email address hidden>
Date: Wed Jun 8 15:17:16 2016 +0300

[Tempest] Handle errored shares correctly using recreation logic

    If we allow share recreation and get some share errored
    making it part of CG, then we fail to create CG snapshot from CG
    that owns this share. Because cleanup step was not reached yet.
    Therefore, consider this case and delete errored shares immediately.

Change-Id: Ib05598de8fbd1c9a735ca91159f3f5cfb86d8889
Closes-Bug: #1577887

Changed in manila:
status:	In Progress → Fix Released

Revision history for this message

Doug Hellmann (doug-hellmann) wrote on 2016-07-14: Fix included in openstack/manila 3.0.0.0b2

This issue was fixed in the openstack/manila 3.0.0.0b2 development milestone.

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-07-18: Fix proposed to manila (stable/mitaka)

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/343822

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-07-25: Fix merged to manila (stable/mitaka)

Reviewed: https://review.openstack.org/343822
Committed: https://git.openstack.org/cgit/openstack/manila/commit/?id=4e2cbdbad06f7cef8ac477885ad3f5c09891f74b
Submitter: Jenkins
Branch: stable/mitaka

commit 4e2cbdbad06f7cef8ac477885ad3f5c09891f74b
Author: Valeriy Ponomaryov <email address hidden>
Date: Wed Jun 8 15:17:16 2016 +0300

[Tempest] Handle errored shares correctly using recreation logic

    Change-Id: Ib05598de8fbd1c9a735ca91159f3f5cfb86d8889
    Closes-Bug: #1577887
    (cherry picked from commit bb01fe9314f990accfbb1ea11c2a63b4fab1c27f)