generic driver: failed to delete share as volume not found

[Felix Ma]

The issue is dup with https://bugs.launchpad.net/manila/+bug/1489573

But the patch (https://review.openstack.org/#/c/217863/) doesn't fix Bug1489573. I hit the same error on master.

It's because self._get_volume is called by self._detach_volume which is ahead of self._deallocate_container

2016-03-29 08:35:38.668 32218 ERROR oslo_messaging.rpc.dispatcher File "/opt/stack/manila/manila/share/manager.py", line 1377, in delete_share_instance
2016-03-29 08:35:38.668 32218 ERROR oslo_messaging.rpc.dispatcher {'status': constants.STATUS_ERROR_DELETING})
2016-03-29 08:35:38.668 32218 ERROR oslo_messaging.rpc.dispatcher File "/usr/lib/python2.7/site-packages/oslo_utils/excutils.py", line 220, in __exit__
2016-03-29 08:35:38.668 32218 ERROR oslo_messaging.rpc.dispatcher self.force_reraise()
2016-03-29 08:35:38.668 32218 ERROR oslo_messaging.rpc.dispatcher File "/usr/lib/python2.7/site-packages/oslo_utils/excutils.py", line 196, in force_reraise
2016-03-29 08:35:38.668 32218 ERROR oslo_messaging.rpc.dispatcher six.reraise(self.type_, self.value, self.tb)
2016-03-29 08:35:38.668 32218 ERROR oslo_messaging.rpc.dispatcher File "/opt/stack/manila/manila/share/manager.py", line 1371, in delete_share_instance
2016-03-29 08:35:38.668 32218 ERROR oslo_messaging.rpc.dispatcher share_server=share_server)
2016-03-29 08:35:38.668 32218 ERROR oslo_messaging.rpc.dispatcher File "/opt/stack/manila/manila/share/drivers/generic.py", line 730, in delete_share
2016-03-29 08:35:38.668 32218 ERROR oslo_messaging.rpc.dispatcher share_server['backend_details'])
2016-03-29 08:35:38.668 32218 ERROR oslo_messaging.rpc.dispatcher File "/opt/stack/manila/manila/share/drivers/generic.py", line 512, in _detach_volume
2016-03-29 08:35:38.668 32218 ERROR oslo_messaging.rpc.dispatcher do_detach()
2016-03-29 08:35:38.668 32218 ERROR oslo_messaging.rpc.dispatcher File "/usr/lib/python2.7/site-packages/oslo_concurrency/lockutils.py", line 271, in inner
2016-03-29 08:35:38.668 32218 ERROR oslo_messaging.rpc.dispatcher return f(*args, **kwargs)
2016-03-29 08:35:38.668 32218 ERROR oslo_messaging.rpc.dispatcher File "/opt/stack/manila/manila/share/drivers/generic.py", line 494, in do_detach
2016-03-29 08:35:38.668 32218 ERROR oslo_messaging.rpc.dispatcher volume = self._get_volume(context, share['id'])
2016-03-29 08:35:38.668 32218 ERROR oslo_messaging.rpc.dispatcher File "/opt/stack/manila/manila/share/drivers/generic.py", line 429, in _get_volume
2016-03-29 08:35:38.668 32218 ERROR oslo_messaging.rpc.dispatcher return self.volume_api.get(context, volume_id)
2016-03-29 08:35:38.668 32218 ERROR oslo_messaging.rpc.dispatcher File "/opt/stack/manila/manila/volume/cinder.py", line 183, in wrapper
2016-03-29 08:35:38.668 32218 ERROR oslo_messaging.rpc.dispatcher raise exception.VolumeNotFound(volume_id=volume_id)
2016-03-29 08:35:38.668 32218 ERROR oslo_messaging.rpc.dispatcher VolumeNotFound: Volume ccd7d1fd-65ba-4b72-871c-7896181bb365 could not be found.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/298607

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/298607
Committed: https://git.openstack.org/cgit/openstack/manila/commit/?id=5b92331be7349d18da4e859df1336db2b3011ee7
Submitter: Jenkins
Branch: master

commit 5b92331be7349d18da4e859df1336db2b3011ee7
Author: maqi <email address hidden>
Date: Tue Mar 29 16:53:28 2016 +0800

    Generic driver: ignore VolumeNotFound in deleting

    Deleting a share will bring it into error_deleting
    if the volume is already deleted. And VolumeNotFound
    exception is raised. The fix will ignore the exception
    and print a warning.

    Change-Id: I82d70b9997a689dd3fd8eefad7dc14c39f9d275a
    Closes-Bug: #1563226

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/300990

[Thierry Carrez (ttx)]

This issue was fixed in the openstack/manila 3.0.0.0b1 development milestone.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/300990
Committed: https://git.openstack.org/cgit/openstack/manila/commit/?id=88a101ced56f10cfaaee337fff06178816d79ea8
Submitter: Jenkins
Branch: stable/mitaka

commit 88a101ced56f10cfaaee337fff06178816d79ea8
Author: maqi <email address hidden>
Date: Tue Mar 29 16:53:28 2016 +0800

    Generic driver: ignore VolumeNotFound in deleting

    Deleting a share will bring it into error_deleting
    if the volume is already deleted. And VolumeNotFound
    exception is raised. The fix will ignore the exception
    and print a warning.

    Change-Id: I82d70b9997a689dd3fd8eefad7dc14c39f9d275a
    Closes-Bug: #1563226
    (cherry picked from commit 5b92331be7349d18da4e859df1336db2b3011ee7)