Share managed with replication_type extra spec does not support replication

[Goutham Pacha Ravi]

Steps to reproduce:

As of https://github.com/openstack/manila/commit/8f7df3fc535140944cf14ff7a7151a8349c6d42e:

1) Create a share on the backend
2) Ask manila to manage this share by providing the export location and use a share type that has extra_spec "replication_type" set to one of 'dr', 'readable' ('dr' when using a NetApp cDOT backend that supports replication and 'readable' when using the reference ZFSonLinux driver configured for replication)
3) Try to create a replica of this share.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/301962

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/301962
Committed: https://git.openstack.org/cgit/openstack/manila/commit/?id=53364e07a3c3da8dc51bb9d8733f42e82e6f82e0
Submitter: Jenkins
Branch: master

commit 53364e07a3c3da8dc51bb9d8733f42e82e6f82e0
Author: yogesh <email address hidden>
Date: Thu Mar 24 17:36:36 2016 -0400

    Handle manage/unmanage for replicated shares

    Managing a share with a share type that has replication_type
    extra_spec must be allowed. Drivers are expected to fail
    this operation if the share was part of a replication relationship
    that Manila does not know about.

    Unmanaging a share with replicas must not be permitted
    until all replicas are removed.

    Managing and unmanaging of snapshots must not
    be permitted for a share that has replicas.

    Modify the NetApp driver for manage_existing to check
    for existing replicas.

    Also fix issue with manage retry where the share
    data was being altered inappropriately by a DB API.

    Closes-Bug: #1561641
    Closes-Bug: #1565903

    Co-Authored-By: Goutham Pacha Ravi <email address hidden>

    Change-Id: I82f1fef1e30114e017efd00fa7da70aceecab94c

[Thierry Carrez (ttx)]

This issue was fixed in the openstack/manila 3.0.0.0b1 development milestone.