OpenStack Shared File Systems Service (Manila)

ShareDriver.update_access method signature is wrong

Bug #1555294 reported by Tiago Pasqualini da Silva
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Shared File Systems Service (Manila)
Fix Released
High
Rodrigo Barbieri
OpenStack Shared File Systems Service (Manila) mitaka-rc1 "RC1"

Bug Description

ShareDriver.update_access method has None as default values for add_rules and delete_rules. This is wrong since these parameters should always be iterable, even if they are empty.

Tiago Pasqualini da Silva (tiago.pasqualini)
Changed in manila:
assignee: nobody → Tiago Pasqualini da Silva (tiago.pasqualini)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to manila (master)

Fix proposed to branch: master
Review: https://review.openstack.org/291153

Changed in manila:
status: New → In Progress
Ben Swartzlander (bswartz)
Changed in manila:
milestone: none → mitaka-rc1
importance: Undecided → High
OpenStack Infra (hudson-openstack)
Changed in manila:
assignee: Tiago Pasqualini da Silva (tiago.pasqualini) → Rodrigo Barbieri (rodrigo-barbieri2010)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to manila (master)

Reviewed: https://review.openstack.org/291153
Committed: https://git.openstack.org/cgit/openstack/manila/commit/?id=02a9a2c3e23cc2c5ab19257549d7ac0144a2192e
Submitter: Jenkins
Branch: master

commit 02a9a2c3e23cc2c5ab19257549d7ac0144a2192e
Author: tpsilva <email address hidden>
Date: Thu Mar 10 09:56:07 2016 -0300

    Remove default values for update_access()

    update_access method has None as default values for add_rules and
    delete_rules. These parameters should always be iterables, so this
    should be removed. This patch removes the default values for this
    method on the base class and on all implemented classes.

    Change-Id: I86f4ccc9d496ec6183bd0fa5be9a77c3451378d5
    Closes-bug: #1555294

Changed in manila:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/manila 2.0.0

This issue was fixed in the openstack/manila 2.0.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.