Bugs about Huawei driver support StandaloneNetworkPlugin

Bug #1549183 reported by zhaohua
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Shared File Systems Service (Manila)
Fix Released
Undecided
zhaohua

Bug Description

In setup_server interface of Huawe driver, it will check the network_info['network_type'].
If the 'network_type' is not 'flat' or 'vlan', the setup_server will fail.
But, when using manila StandaloneNetworkPlugin, the 'network_type' can be 'None'(which also represent 'flat'), which cause an unexpected error.

So, should add 'None' as a legal value of 'network_type' .

And when using manila StandaloneNetworkPlugin without 'standalone_network_plugin_segmentation_id', vlan will not be created.
So, use the number of vlan to sort the port is not effective.(This will also affect other network plugins with 'flat' type)

Should add another way to sort the port(maybe the number of logic ip)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to manila (master)

Fix proposed to branch: master
Review: https://review.openstack.org/284033

Changed in manila:
assignee: nobody → zhaohua (zhaohua-zhao)
status: New → In Progress
Revision history for this message
Valeriy Ponomaryov (vponomaryov) wrote :

Standalone network plugin has two options:
- standalone_network_plugin_network_type
- standalone_network_plugin_segmentation_id

So, statement in bug description is not fully true. It is None by default, that's all. But it can be 'vlan' and can have 'segmentation id'.

So, if your driver expects 'vlan' always, then it is configuration error.

Revision history for this message
zhaohua (zhaohua-zhao) wrote :

Sorry for the mistake.
This bugs was proposed by our users.They use Standalone network plugin without "standalone_network_plugin_network_type" and "standalone_network_plugin_segmentation_id", and found huawei driver worked unexpectedly.
So we decided to make this change.
I will modify the bug description more reasonable.

zhaohua (zhaohua-zhao)
description: updated
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to manila (master)

Reviewed: https://review.openstack.org/284033
Committed: https://git.openstack.org/cgit/openstack/manila/commit/?id=bc24ef82ecac3c6ab55ca8733eeb3a16d0ffe212
Submitter: Jenkins
Branch: master

commit bc24ef82ecac3c6ab55ca8733eeb3a16d0ffe212
Author: zhaohua <email address hidden>
Date: Wed Feb 24 17:41:29 2016 +0800

    Huawei driver improve support of StandaloneNetworkPlugin

    Add 'None' as a legal value of 'network_type'
    Add choose the port which has least number of logic port
    to setup server in flat network.

    Change-Id: Id6bd63fce62004f8ff54e6959931cb7a175bbf93
    Closes-Bug: #1549183

Changed in manila:
status: In Progress → Fix Released
Revision history for this message
Doug Hellmann (doug-hellmann) wrote : Fix included in openstack/manila 2.0.0.0b3

This issue was fixed in the openstack/manila 2.0.0.0b3 development milestone.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.