wrong calculation on user quota

[TaoBai]

Here is the failure test case:

In a pure manila environment. Create two users for telent "demo" : "user1" and "user2"

Step1:
create two shares and each 1 share 1GB with "user1". You could check the quota usage through "manila absolute-limits" that two shares and 2 GB are used
This is step is right.

Step2:
Change to "user2". Delete the two shares just created by user1 . Then use "manila absolute-limits" to check the quota usage, this 1 share and 1 GB is used even there is no share left any more.

I compared with Nova db with similiar case found that the big difference is in the db table "quota_usages". If "user2" delete the resource created by "user1". In nova, the user1's quota usage will be decreased even you are using "user2"but for manila, user2's quota usage decreased until to "-1".

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/289992

[TaoBai (baitao2020)]

Hoping this bugfix could be cherry pick to Liberty release. thanks

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/liberty
Review: https://review.openstack.org/290998

[OpenStack Infra (hudson-openstack)]

Change abandoned by Tom Patzig (<email address hidden>) on branch: stable/liberty
Review: https://review.openstack.org/290998
Reason: will be cherry-picked again, once master change merged

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/289992
Committed: https://git.openstack.org/cgit/openstack/manila/commit/?id=8d3e72f8b25ca9ae86544dc7ab249f9941dee5f1
Submitter: Jenkins
Branch: master

commit 8d3e72f8b25ca9ae86544dc7ab249f9941dee5f1
Author: Tom Patzig <email address hidden>
Date: Tue Mar 8 16:55:04 2016 +0100

    Update quota of proper user on resource delete

    When deleting a resource (share, snapshot, share-network) the quota
    usage of the current user gets updated, which might not be the same
    user, who created that resource. That means the quota usage will never
    be reduced for initial user.
    This fix adds the resources user_id to the quota update statements, to
    update the quota_usage for the user, that created this resource,
    irregardless who deletes it.

    Change-Id: Iefe8f4d0e7c526e3ed94c1994ba62f1a2a929ba2
    Closes-Bug: #1542598

[Doug Hellmann (doug-hellmann)]

This issue was fixed in the openstack/manila 2.0.0.0rc1 release candidate.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/manila 2.0.0 release.

[OpenStack Infra (hudson-openstack)]

Change abandoned by Joshua Hesketh (<email address hidden>) on branch: stable/liberty
Review: https://review.openstack.org/290998
Reason: This branch (stable/liberty) is at End Of Life