Bug about thin or thick type in huawei driver

[zhaohua]

In the desigin of huawei driver, there are 3 ways to decide which type of share to create(Thin or Thick):
1.If "capabilities:thin_provision=<is> True or False" in the share_type, it will be used(thin share will be created if "capabilities:thin_provision=<is> True", thick share will be created if "capabilities:thin_provision=<is> False")
2.If "thin_provision" is not present in the share_type, the config value of "AllocType" in the config file will be used(thin share will be created if "AllocType=Thin", thick share will be created if "AllocType=Thick")
3.If two of aboves are not present, then thick share will be created by default.

But, now there is a bug in the code that makes the second and third ways not effective.
The code add a default value to the share_type(which is "thin_provision=False") which makes first way always effective.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/276977

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/276977
Committed: https://git.openstack.org/cgit/openstack/manila/commit/?id=c2d285e089c0f4496476062ef961b2387fcb214a
Submitter: Jenkins
Branch: master

commit c2d285e089c0f4496476062ef961b2387fcb214a
Author: zhaohua <email address hidden>
Date: Fri Feb 5 11:16:06 2016 +0800

    Three ways to set Thin/Thick Type in Huawei driver

    1.If thin_provisioning is set in the share type extra-specs,
      it will be used(thin share will be created if "capabilities:
      thin_provisioning=<is> True", thick share will be created if
      "capabilities:thin_provisioning=<is> False")
    2.If "thin_provisioning" is not present in the share_type, the config value
      of "AllocType" in the config file will be used(thin share will be created
      if "AllocType=Thin", thick share will be created if "AllocType=Thick")
    3.If two of aboves are not present, then thick share will be created by default.

    Change-Id: I8153aa79fb04a4221675d7ec2e4b24947ec6f9d7
    Closes-Bug: #1542133

[Doug Hellmann (doug-hellmann)]

This issue was fixed in the openstack/manila 2.0.0.0b3 development milestone.