Hacking rule for underscore import doesn't work

Bug #1541780 reported by Marc Koderer
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Cinder
Fix Released
Undecided
Marc Koderer
OpenStack Shared File Systems Service (Manila)
Won't Fix
Undecided
Marc Koderer

Bug Description

Hacking rule seems not to work reliable see:
https://review.openstack.org/#/c/270754/

Marc Koderer (m-koderer)
Changed in manila:
assignee: nobody → Marc Koderer (m-koderer)
Changed in manila:
status: New → In Progress
Revision history for this message
Marc Koderer (m-koderer) wrote :

The hacking rule also accepts line with:
  from cinder.i18n import _LW

which should be ignored

Changed in cinder:
assignee: nobody → Marc Koderer (m-koderer)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder (master)

Fix proposed to branch: master
Review: https://review.openstack.org/276198

Changed in cinder:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cinder (master)

Reviewed: https://review.openstack.org/276198
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=9c6ef735d371d630371df1b7b9f07e82d40c4b37
Submitter: Jenkins
Branch: master

commit 9c6ef735d371d630371df1b7b9f07e82d40c4b37
Author: Marc Koderer <email address hidden>
Date: Thu Feb 4 13:43:33 2016 +0100

    Fix issue in hacking with underscore imports

    Hacking rule for underscore imports _() are not working correctly.
    It also matches _.* imports like "import _LE"

    See review: https://review.openstack.org/#/c/270754/

    Closes-bug: 1541780
    Change-Id: Ibdef35e1896882a8dfe3165dba989255639e61ba

Changed in cinder:
status: In Progress → Fix Released
Changed in manila:
milestone: none → newton-1
importance: Undecided → Low
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to manila (master)

Fix proposed to branch: master
Review: https://review.openstack.org/320273

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on manila (master)

Change abandoned by Marc Koderer (<email address hidden>) on branch: master
Review: https://review.openstack.org/320273

Changed in manila:
importance: Low → Undecided
status: In Progress → Incomplete
Revision history for this message
Jason Grosso (jgrosso) wrote :

Goutham what would you consider the priority for this bug, who shall I assign this too

Revision history for this message
Jason Grosso (jgrosso) wrote :

closing this abandoned change and no responsers

Changed in manila:
status: Incomplete → Won't Fix
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.