Extra specs '=' operator does >= test instead of equals

Bug #1538243 reported by Mark Sturdevant
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Shared File Systems Service (Manila)
Fix Released
Undecided
Andrei Ta

Bug Description

Spec "= 124" matches value "123" because the code is doing float(x) >= float(y). This is obviously wrong.

Note: There are also correctly written alternaves '==', '>=',... so a work-around exists for equal or >=.

Andrei Ta (ata-o)
Changed in manila:
assignee: nobody → Andrei Ta (ata-o)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to manila (master)

Fix proposed to branch: master
Review: https://review.openstack.org/280341

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on manila (master)

Change abandoned by Andrei Ta (<email address hidden>) on branch: master
Review: https://review.openstack.org/280341

Andrei Ta (ata-o)
Changed in manila:
assignee: Andrei Ta (ata-o) → nobody
Andrei Ta (ata-o)
Changed in manila:
assignee: nobody → Andrei Ta (ata-o)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to manila (master)

Fix proposed to branch: master
Review: https://review.openstack.org/282063

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to manila (master)

Reviewed: https://review.openstack.org/282063
Committed: https://git.openstack.org/cgit/openstack/manila/commit/?id=bd88709204dc61f1e0c75e0e077e6b144162bd29
Submitter: Jenkins
Branch: master

commit bd88709204dc61f1e0c75e0e077e6b144162bd29
Author: Andrei Ta <email address hidden>
Date: Thu Feb 18 15:09:03 2016 -0600

    Add additional documentation on extra spec operations.

    Change-Id: I4f315f4454296231c79429b3ab326318bd5005fa
    Closes-Bug: #1538243

Changed in manila:
status: In Progress → Fix Released
Revision history for this message
Doug Hellmann (doug-hellmann) wrote : Fix included in openstack/manila 2.0.0.0b3

This issue was fixed in the openstack/manila 2.0.0.0b3 development milestone.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.