One of negative tempest tests for services API makes not safe assertions

Bug #1531667 reported by Valeriy Ponomaryov
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Shared File Systems Service (Manila)
Fix Released
High
NidhiMittalHada

Bug Description

Test "test_get_service_by_invalid_params" located at [1] performs not safe assertions where two lists are compared and it fails when order of inner elements is different, but this case should be considered OK.

[1] https://github.com/openstack/manila/blob/2467ccf2/manila_tempest_tests/tests/api/admin/test_services_negative.py#L50

Tags: tempest
Revision history for this message
Valeriy Ponomaryov (vponomaryov) wrote :

This bug makes Tempest jobs more unstable, so, should be fixed soon.

description: updated
tags: added: tempest
Changed in manila:
importance: Undecided → High
Revision history for this message
NidhiMittalHada (nidhimittal19) wrote :

working on this.

Changed in manila:
assignee: nobody → NidhiMittalHada (nidhimittal19)
Changed in manila:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to manila (master)

Fix proposed to branch: master
Review: https://review.openstack.org/264734

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to manila (master)

Reviewed: https://review.openstack.org/264734
Committed: https://git.openstack.org/cgit/openstack/manila/commit/?id=a700e1e5d31521d459edf3d098bbfe4f8b9b4790
Submitter: Jenkins
Branch: master

commit a700e1e5d31521d459edf3d098bbfe4f8b9b4790
Author: nidhimittalhada <email address hidden>
Date: Thu Jan 7 17:03:46 2016 +0530

    A tempest test in services API using unsafe assert

    Test "test_get_service_by_invalid_params" performs
    unsafe assertions where two lists are compared and it
    fails when order of inner elements is different, but
    this case should be considered OK.

    Change-Id: I15efc590d45afb6e025c0e920177c58e57eebadb
    Closes-Bug: #1531667

Changed in manila:
status: In Progress → Fix Released
Revision history for this message
Thierry Carrez (ttx) wrote : Fix included in openstack/manila 2.0.0.0b2

This issue was fixed in the openstack/manila 2.0.0.0b2 development milestone.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.