Use constants instead of literals

Bug #1529015 reported by liucheng
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Shared File Systems Service (Manila)
Fix Released
Undecided
liucheng

Bug Description

Some literals should not show up, for example,"fs_info['ALLOCTYPE'] != '1'", it's better to use constants .

Changed in manila:
assignee: nobody → NidhiMittalHada (nidhimittal19)
liucheng (liucheng20)
Changed in manila:
assignee: NidhiMittalHada (nidhimittal19) → liucheng (liucheng20)
liucheng (liucheng20)
description: updated
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to manila (master)

Fix proposed to branch: master
Review: https://review.openstack.org/264042

Changed in manila:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to manila (master)

Reviewed: https://review.openstack.org/264042
Committed: https://git.openstack.org/cgit/openstack/manila/commit/?id=49761cd38a08c52e5fc5b90188fdeade5e0906ba
Submitter: Jenkins
Branch: master

commit 49761cd38a08c52e5fc5b90188fdeade5e0906ba
Author: liucheng <email address hidden>
Date: Wed Jan 6 14:26:19 2016 +0800

    Use constants instead of literals in Huawei Driver

    We judged filesystem alloctype by literals,
    now we change these literals to constants.

    Change-Id: Iaeb64ed83b4c44e3e7d150c615ad03f8b1b4ce90
    Closes-Bug: #1529015

Changed in manila:
status: In Progress → Fix Released
Revision history for this message
Thierry Carrez (ttx) wrote : Fix included in openstack/manila 2.0.0.0b2

This issue was fixed in the openstack/manila 2.0.0.0b2 development milestone.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.