HPE3PAR fails to find SMB share for allow access

Bug #1528936 reported by Mark Sturdevant
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Shared File Systems Service (Manila)
Fix Released
Medium
Mark Sturdevant

Bug Description

Access level was not supported by the HP/HPE driver in Liberty. Adding access levels in Mitaka (driver version 2.0.1) introduced dual shares for NFS with osf-ro prefix for readonly shares. The CIFS/SMB does not use dual shares, but it does still use osf-ro prefix for the special case of 3PAR read-only shares from snapshot. The 2.0.1 code is not able to find the CIFS share when the access rule doesn't match the expected prefix. I.e., CIFS read-only should be allowed on a CIFS share with either prefix and CIFS read-write should at least find a share with either prefix (so access can be validated later).

Changed in manila:
assignee: nobody → Mark Sturdevant (mark-sturdevant)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to manila (master)

Fix proposed to branch: master
Review: https://review.openstack.org/261086

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to manila (master)

Reviewed: https://review.openstack.org/261086
Committed: https://git.openstack.org/cgit/openstack/manila/commit/?id=cf36c111c86a61f454e1ab6c77a6da06b0dcb257
Submitter: Jenkins
Branch: master

commit cf36c111c86a61f454e1ab6c77a6da06b0dcb257
Author: mark.sturdevant <email address hidden>
Date: Wed Dec 23 11:25:47 2015 -0800

    HPE3PAR finds CIFS share with either prefix

    The share prefix can be osf- or osf-ro depending
    on whether it is a readonly share. CIFS does not
    create dual shares like NFS, but can use either
    prefix because of the readonly snapshot special
    case. So the CIFS implementation needs to find the
    share or the "other share" for access rules.
    Most of the NFS code is reused for this.

    Unlike NFS a regular CIFS share supports both RO
    and RW users.

    An CIFS osf-ro share should only allow RO users.
    In this case, find the share and later validate
    the access rule.

    Change-Id: I1e7a504c276e0e28f56a564802af17061fe09037
    Closes-Bug: #1528936

Changed in manila:
status: In Progress → Fix Released
Changed in manila:
importance: Undecided → Low
importance: Low → Medium
Revision history for this message
Thierry Carrez (ttx) wrote : Fix included in openstack/manila 2.0.0.0b2

This issue was fixed in the openstack/manila 2.0.0.0b2 development milestone.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.