"Property is deprecated. Please use appropriate property from share instance." spams API logs

[Matt Riedemann]

This change deprecated getting a few properties from the share db object:

https://github.com/openstack/manila/commit/f5f36e3bfc11d39569cc084e132ce32cadb5af56

And one should now get them from the share_instance.

The API view builder code still accesses the properties from the share object, so we have a ton of deprecation warnings in the API logs:

http://logs.openstack.org/51/253151/1/gate/gate-manila-tempest-dsvm-neutron/7e62321/logs/screen-m-api.txt.gz?level=TRACE

2015-12-19 05:40:49.053 31957 WARNING manila.db.sqlalchemy.models [req-1ce2451f-0139-4bf4-95e8-623f5e336ce2 - - - - -] Property 'host' is deprecated. Please use appropriate property from share instance.
2015-12-19 05:40:49.053 31957 WARNING manila.db.sqlalchemy.models [req-1ce2451f-0139-4bf4-95e8-623f5e336ce2 - - - - -] Property 'share_server_id' is deprecated. Please use appropriate property from share instance.
2015-12-19 05:40:49.053 31957 WARNING manila.db.sqlalchemy.models [req-1ce2451f-0139-4bf4-95e8-623f5e336ce2 - - - - -] Property 'share_network_id' is deprecated. Please use appropriate property from share instance.
2015-12-19 05:40:49.054 31957 WARNING manila.db.sqlalchemy.models [req-1ce2451f-0139-4bf4-95e8-623f5e336ce2 - - - - -] Property 'availability_zone' is deprecated. Please use appropriate property from share instance.

We should really just get this cleaned up, the change was made back in 8/7/15.

[Matt Riedemann (mriedem)]

Shows up about 22+ million times in the gate for manila in a week:

http://logstash.openstack.org/#dashboard/file/logstash.json?query=message:%5C%22is%20deprecated.%20Please%20use%20appropriate%20property%20from%20share%20instance.%5C%22%20AND%20project:%5C%22openstack/manila%5C%22