| 2015-12-21 13:40:06 |
Valeriy Ponomaryov |
bug |
|
|
added bug |
| 2015-12-21 13:41:24 |
Valeriy Ponomaryov |
summary |
manila unit tests should not mock DB methods |
manila unit tests should not mock DB functions |
|
| 2015-12-21 13:41:32 |
Valeriy Ponomaryov |
tags |
|
db tests |
|
| 2015-12-21 13:41:54 |
Valeriy Ponomaryov |
description |
Manila has lots of unit tests that mock DB functions and verify things based on fake return values. This makes harm in several ways:
1) Return results are dicts and not DB objects, hence, DB objects methods can not be used.
2) Having fake dict results mocks possible incorrect answer from DB function
Proposal: use existing test DB in unit tests, not mocking DB functions. |
Manila has lots of unit tests that mock DB functions and verify things based on fake return values. This makes harm in several ways:
1) Return results are dicts and not DB objects, hence, DB objects methods can not be used in main code.
2) Having fake dict results mocks possible incorrect answer from DB function
Proposal: use existing test DB in unit tests, not mocking DB functions. |
|
| 2015-12-21 13:42:26 |
Valeriy Ponomaryov |
description |
Manila has lots of unit tests that mock DB functions and verify things based on fake return values. This makes harm in several ways:
1) Return results are dicts and not DB objects, hence, DB objects methods can not be used in main code.
2) Having fake dict results mocks possible incorrect answer from DB function
Proposal: use existing test DB in unit tests, not mocking DB functions. |
Manila has lots of unit tests that mock DB functions and verify things based on fake return values. This makes harm in several ways:
1) Return results are dicts and not DB objects, hence, DB objects methods can not be used in main code.
2) Having fake dict results mocks it is possible to have incorrect answer from DB function.
Proposal: use existing test DB in unit tests, not mocking DB functions. |
|
| 2015-12-21 13:42:39 |
Valeriy Ponomaryov |
manila: importance |
Undecided |
Low |
|
| 2015-12-21 13:43:11 |
OpenStack Infra |
manila: status |
New |
In Progress |
|
| 2015-12-21 13:43:11 |
OpenStack Infra |
manila: assignee |
|
Valeriy Ponomaryov (vponomaryov) |
|
| 2016-01-08 02:51:43 |
OpenStack Infra |
manila: assignee |
Valeriy Ponomaryov (vponomaryov) |
Clinton Knight (clintonk) |
|
| 2016-01-08 02:52:36 |
Clinton Knight |
manila: assignee |
Clinton Knight (clintonk) |
|
|
| 2016-01-08 02:52:55 |
Clinton Knight |
manila: assignee |
|
Valeriy Ponomaryov (vponomaryov) |
|
| 2016-02-24 02:04:18 |
OpenStack Infra |
tags |
db tests |
db in-stable-liberty tests |
|
| 2016-03-09 14:49:40 |
Valeriy Ponomaryov |
manila: assignee |
Valeriy Ponomaryov (vponomaryov) |
|
|
| 2016-03-21 14:24:10 |
Valeriy Ponomaryov |
manila: status |
In Progress |
New |
|
| 2016-04-05 07:17:43 |
NidhiMittalHada |
manila: assignee |
|
NidhiMittalHada (nidhimittal19) |
|
| 2019-03-19 17:36:02 |
Goutham Pacha Ravi |
tags |
db in-stable-liberty tests |
db low-hanging-fruit tests |
|
| 2019-03-19 17:36:06 |
Goutham Pacha Ravi |
manila: status |
New |
Confirmed |
|
| 2019-03-19 17:39:10 |
Goutham Pacha Ravi |
manila: assignee |
NidhiMittalHada (nidhimittal19) |
|
|
| 2019-03-19 17:39:19 |
Goutham Pacha Ravi |
manila: importance |
Low |
Wishlist |
|
| 2022-04-28 12:58:37 |
Vida Haririan |
manila: status |
Confirmed |
Incomplete |
|
| 2022-06-28 04:17:17 |
Launchpad Janitor |
manila: status |
Incomplete |
Expired |
|
