share_volume_fstype configuration option not used

Bug #1525933 reported by Thomas Bechtold
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Shared File Systems Service (Manila)
Won't Fix
Low
Unassigned

Bug Description

When specifying "share_volume_fstype=ext3" in the [DEFAULT] section, still ext4 is used. Changing the default in the code (share/drivers/generic.py) to ext3 leads to using ext3. So the code uses currently always the default.

Tags: driver generic
tags: added: liberty-backport-potential
Changed in manila:
assignee: nobody → NidhiMittalHada (nidhimittal19)
Revision history for this message
NidhiMittalHada (nidhimittal19) wrote :

Hi Thomas

As discussed on IRC

The experiments i did to understand the bug .. says that

if i use share_volume_fstype=ext3 in [DEFAULT] in /etc/manila/manila.conf file
it remains ext4 as you mentioned.

but
if we set share_volume_fstype=ext3 in [generic1] in the group as
[generic1]
driver_handles_share_servers = True
service_instance_user = manila
service_image_name = manila-service-image
path_to_private_key = /home/stack/.ssh/id_rsa
path_to_public_key = /home/stack/.ssh/id_rsa.pub
share_backend_name = GENERIC1
share_driver = manila.share.drivers.generic.GenericShareDriver
share_volume_fstype=ext3

i am not facing any bug
its coming correctly.

my doubt is ..

is it right to put it in generic section .. ??

Changed in manila:
status: New → In Progress
Revision history for this message
NidhiMittalHada (nidhimittal19) wrote :

HI Thomas,

Could you get time to check this ..

Please let me know if this still requires a fix or it can be
resolved as it is..

Thanks
Nidhi

Revision history for this message
Thomas Bechtold (toabctl) wrote :

Specifying share_volume_fstype in the backend section solves it. Not sure if it's still a bug that it doesn't work to specify share_volume_fstype for *all* backends in the [DEFAULT] section.
For me it's fine to specify it in every backend section.

Revision history for this message
NidhiMittalHada (nidhimittal19) wrote :

So should we mark bug as resolved .. ? or its still a bug.. May be Ben or Valeriy can comment ?

Revision history for this message
Ben Swartzlander (bswartz) wrote :

If the option doesn't inherit from the default section to the individual backend sections, it souns like an oslo config issue. If there's a bug in Manila I'd like to see it fixed, but this one feels incredibly low priority.

Changed in manila:
importance: Undecided → Low
Changed in manila:
assignee: NidhiMittalHada (nidhimittal19) → nobody
Tom Barron (tpb)
tags: added: driver generic
removed: liberty-backport-potential
Revision history for this message
Jason Grosso (jgrosso) wrote :

Hey all is any looking at this its a very old bug?

Revision history for this message
Tom Barron (tpb) wrote :

I'm inclined to mark this as won't fix. We should be setting this in the backend stanza for backends that need it. If there is a bug about not inheriting it from DEFAULT then as Ben says it's very now priority and would be addressed in oslo rather than in manila.

Changed in manila:
status: In Progress → Won't Fix
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.