Some "NotFound" manila exceptions return response code 500 instead of 404

Bug #1525860 reported by Valeriy Ponomaryov
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Shared File Systems Service (Manila)
Fix Released
Low
Daiki Kato

Bug Description

Following NotFound exceptions return response code 500 instad of 404:

- StorageResourceNotFound
- SnapshotNotFound
- ShareResourceNotFound

Also, one of unit tests verify that it returns incorrect code - https://github.com/openstack/manila/blob/616ffabe/manila/tests/test_exception.py#L455

Changed in manila:
importance: Undecided → Low
Daiki Kato (d-kato)
Changed in manila:
assignee: nobody → daiki kato (d-kato)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to manila (master)

Fix proposed to branch: master
Review: https://review.openstack.org/261440

Changed in manila:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to manila (master)

Reviewed: https://review.openstack.org/261440
Committed: https://git.openstack.org/cgit/openstack/manila/commit/?id=d29e611c2fe8755c26e33f03883af29a9acd7d3e
Submitter: Jenkins
Branch: master

commit d29e611c2fe8755c26e33f03883af29a9acd7d3e
Author: daiki kato <email address hidden>
Date: Fri Dec 25 07:25:12 2015 +0000

    Fix response code for various NotFound exceptions

    Fix response code for "NotFound"-like Manila exceptions.

    - StorageResourceNotFound
    - SnapshotNotFound
    - ShareResourceNotFound

    Change-Id: Ic7be15c2f8951e512de88d1f559ec677ba4bd78e
    Closes-Bug: #1525860

Changed in manila:
status: In Progress → Fix Released
Revision history for this message
Thierry Carrez (ttx) wrote : Fix included in openstack/manila 2.0.0.0b2

This issue was fixed in the openstack/manila 2.0.0.0b2 development milestone.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.