Create share API without checking share network in DHSS=true mode

Bug #1525125 reported by zhongjun
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Shared File Systems Service (Manila)
Fix Released
Low
zhongjun

Bug Description

Create share API without checking share network in DHSS=true mode. But in Manila-ui can check the share network when you create a share.

How to reproduce:
1. create share type
# manila type-create test_type_name True

2. create a share
# manila create test_name NFS 1 --share-type=test_type_name

It will send create share command to driver, But the right thing to do is framework should be intercepted, just like manila-ui.
When I create a share with the share type(DHSS=true ) , and If I am not choose the share network, I can not create a share.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to manila (master)

Fix proposed to branch: master
Review: https://review.openstack.org/256353

Changed in manila:
assignee: nobody → zhongjun (jun-zhongjun)
status: New → In Progress
Changed in manila:
importance: Undecided → Low
milestone: none → mitaka-rc1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to manila (master)

Reviewed: https://review.openstack.org/256353
Committed: https://git.openstack.org/cgit/openstack/manila/commit/?id=3ef988eddeff6fc05313915d3ef17196e67db023
Submitter: Jenkins
Branch: master

commit 3ef988eddeff6fc05313915d3ef17196e67db023
Author: zhongjun <email address hidden>
Date: Fri Dec 11 19:08:03 2015 +0800

    Check share-network in 'share create' API

    For the moment it is possible to schedule share creation with DHSS=true
    share type but without share network. But it makes no sense, and
    expected to fail. So, perform check on API level.

    APIImpact
    When create share with share type(DHSS=true) and not input share
    network, API will return HTTPBadRequest and message:
    "Share network must be set when the driver_handles_share_servers
    is true."

    Closes-Bug: #1525125
    Change-Id: Icdfabff7b1d3b6e95dd1dd58a0155de637056657

Changed in manila:
status: In Progress → Fix Released
Revision history for this message
Doug Hellmann (doug-hellmann) wrote : Fix included in openstack/manila 2.0.0.0rc1

This issue was fixed in the openstack/manila 2.0.0.0rc1 release candidate.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/manila 2.0.0

This issue was fixed in the openstack/manila 2.0.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.