OpenStack Shared File Systems Service (Manila)

.pyc file should be deleted before running test

Bug #1520036 reported by yuanying
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Shared File Systems Service (Manila)
Fix Released
Undecided
yuanying
python-manilaclient
Fix Released
Undecided
yuanying

Bug Description

When running test .pyc should be deleted first, because if some test modules are deleted which .pyc files are not, that .pyc files may cause unexpected error.

yuanying (yuanying)
Changed in manila:
assignee: nobody → yuanying (ootsuka)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to manila (master)

Fix proposed to branch: master
Review: https://review.openstack.org/250113

Changed in manila:
status: New → In Progress
yuanying (yuanying)
Changed in python-manilaclient:
assignee: nobody → yuanying (ootsuka)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-manilaclient (master)

Fix proposed to branch: master
Review: https://review.openstack.org/250114

Changed in python-manilaclient:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-manilaclient (master)

Reviewed: https://review.openstack.org/250114
Committed: https://git.openstack.org/cgit/openstack/python-manilaclient/commit/?id=4cad48c9135dbd2c04aaef24e2ca90826a95d4ed
Submitter: Jenkins
Branch: master

commit 4cad48c9135dbd2c04aaef24e2ca90826a95d4ed
Author: OTSUKA, Yuanying <email address hidden>
Date: Thu Nov 26 11:01:59 2015 +0900

    Delete python bytecode before every test run

    Because python creates pyc files during tox runs, certain
    changes in the tree, like deletes of files, or switching
    branches, can create spurious errors.

    Change-Id: Ie1de30cab00d81fc6712e554cbd3b28db29213cd
    Closes-Bug: #1520036

Changed in python-manilaclient:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to manila (master)

Reviewed: https://review.openstack.org/250113
Committed: https://git.openstack.org/cgit/openstack/manila/commit/?id=40f5e2234acc52617bc2eab5ec98c800e3912eb7
Submitter: Jenkins
Branch: master

commit 40f5e2234acc52617bc2eab5ec98c800e3912eb7
Author: OTSUKA, Yuanying <email address hidden>
Date: Thu Nov 26 10:58:03 2015 +0900

    Delete python bytecode before every test run

    Because python creates pyc files during tox runs, certain
    changes in the tree, like deletes of files, or switching
    branches, can create spurious errors.

    Change-Id: I9e3b8c8cb0e6df8f3b67ec9d4fc5bc5d25356d16
    Closes-Bug: #1520036

Changed in manila:
status: In Progress → Fix Committed
Revision history for this message
Doug Hellmann (doug-hellmann) wrote : Fix included in openstack/python-manilaclient 1.6.0

This issue was fixed in the openstack/python-manilaclient 1.6.0 release.

Revision history for this message
Thierry Carrez (ttx) wrote : Fix included in openstack/manila 2.0.0.0b2

This issue was fixed in the openstack/manila 2.0.0.0b2 development milestone.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to manila (stable/liberty)

Fix proposed to branch: stable/liberty
Review: https://review.openstack.org/336922

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on manila (stable/liberty)

Change abandoned by Matt Riedemann (<email address hidden>) on branch: stable/liberty
Review: https://review.openstack.org/336922
Reason: This has to come after https://review.openstack.org/#/c/334220/ so kind of pointless in doing this before it.

Goutham Pacha Ravi (gouthamr)
Changed in python-manilaclient:
status: Fix Committed → Fix Released
Changed in manila:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.