Wrong place for sourcing devstack functions in CI hooks

Bug #1519028 reported by Valeriy Ponomaryov
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Shared File Systems Service (Manila)
Fix Released
High
Valeriy Ponomaryov

Bug Description

Commit [1] moved common logic for CI hooks to separate file, but it depends on some devstack functions, that should be "sourced" in this common file. But there are sourced in place of usage, that is not correct and leads to errors when used outside of manila's hooks.

[1] https://github.com/openstack/manila/commit/6b8319e3

Tags: ci
Changed in manila:
importance: Undecided → High
assignee: nobody → Valeriy Ponomaryov (vponomaryov)
milestone: none → mitaka-1
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to manila (master)

Fix proposed to branch: master
Review: https://review.openstack.org/248811

tags: added: ci
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to manila (master)

Reviewed: https://review.openstack.org/248811
Committed: https://git.openstack.org/cgit/openstack/manila/commit/?id=037ba11389e809d6ffea2ab901f80981e4309a6d
Submitter: Jenkins
Branch: master

commit 037ba11389e809d6ffea2ab901f80981e4309a6d
Author: Valeriy Ponomaryov <email address hidden>
Date: Mon Nov 23 18:38:55 2015 +0200

    Fix import of devstack functions for common CI script

    Commit [1] moved common logic for CI hooks to separate file, but it
    depends on some devstack functions, that should be "sourced" in this
    common file. So, this common file works in manila hooks, because they
    import devstack functions separately, but it will not work if some other
    scripts use it and do not import devstack functions.

    [1] I94514405628ab8337d1f4153e431f064614e3596

    Change-Id: I919fea046e556d601a7680ea9bac16c1a9b7343c
    Closes-Bug: #1519028

Changed in manila:
status: In Progress → Fix Committed
Revision history for this message
Doug Hellmann (doug-hellmann) wrote : Fix included in openstack/manila 2.0.0.0b1

This issue was fixed in the openstack/manila 2.0.0.0b1 development milestone.

Changed in manila:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.