Generic driver does not wait for user share servers

[Lucian Petrut]

If the driver does not handle share servers, during init, it verifies that the pre-configured share server exists and is available (behavior recently introduced by I325d6461c4b12f481769bb01f792ef850dba789c).

If the instance does not exist when the service starts, the driver will remain permanently in an uninitialized state, even if the according instance is created meanwhile.

The driver could poll for the share server instead, waiting for it to become active, logging a meaningful message and getting out of the uninitialized state afterwards. This could ease the Generic driver deployment as well as other drivers based on it.

At the moment, the Windows SMB driver CI jobs fail due to this issue, when DHSS is set to false (in which case the Nova Hyper-V nodes are deployed after Manila).

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/236034

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/236034
Committed: https://git.openstack.org/cgit/openstack/manila/commit/?id=4e03dddcb5e3f820998acc261fce768027234c7a
Submitter: Jenkins
Branch: master

commit 4e03dddcb5e3f820998acc261fce768027234c7a
Author: Lucian Petrut <email address hidden>
Date: Fri Oct 16 20:53:12 2015 +0300

    Generic driver: wait for common server during setup

    If the driver does not handle share servers, during init, it
    verifies that the pre-configured share server exists and is available
    (behavior recently introduced by
    I325d6461c4b12f481769bb01f792ef850dba789c).

    If the instance does not exist when the service starts, the driver
    will remain permanently in an uninitialized state, even if the
    according instance is created meanwhile.

    This patch changes this behavior, waiting for the common server
    to become active, logging a meaningful message. This can considerably
    ease the deployment of this driver as well as other drivers based
    on it.

    At the moment, the Windows SMB driver CI jobs fail due to this issue,
    when DHSS is set to false (in which case the Nova Hyper-V nodes are
    deployed after Manila).

    Change-Id: Icf446ca25cf0c64396223611c6271d4c6445cb4d
    Closes-Bug: #1506951

[Doug Hellmann (doug-hellmann)]

This issue was fixed in the openstack/manila 2.0.0.0b1 development milestone.