glusterfs-native: dyamic-auth gluster option is not set properly

Bug #1506577 reported by Csaba Henk
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Shared File Systems Service (Manila)
Fix Released
Undecided
Csaba Henk

Bug Description

The value of the server.dynamic-auth GlusterFS option that was introduced to fix https://bugs.launchpad.net/manila/+bug/1489081 is not parsed correctly in the respective fix, so the fix is defunct and phenomena reported in that bug still occurs.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to manila (master)

Fix proposed to branch: master
Review: https://review.openstack.org/235522

Changed in manila:
assignee: nobody → Csaba Henk (chenk)
status: New → In Progress
Csaba Henk (chenk)
summary: - glusterfs-native: dyamic-auth gluster option is not set properyl
+ glusterfs-native: dyamic-auth gluster option is not set properly
tags: added: liberty-backport-potential
Csaba Henk (chenk)
description: updated
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to manila (master)

Reviewed: https://review.openstack.org/235522
Committed: https://git.openstack.org/cgit/openstack/manila/commit/?id=c38d4969533efbd99e586f935edddf10a63e64a4
Submitter: Jenkins
Branch: master

commit c38d4969533efbd99e586f935edddf10a63e64a4
Author: Csaba Henk <email address hidden>
Date: Thu Oct 15 19:54:37 2015 +0200

    glusterfs_native: fix parsing of the dynamic-auth option

    The full name of the 'dynamic-auth' GlusterFS option
    is 'server.dynamic-auth'. When we started to make use
    of it in https://review.openstack.org/229409, we just
    used its short form, 'dynamic-auth'. That actually
    *should* work but due to some weakness in the GlusterFS
    instrumentation code, it doesn't.

    Fix the situation for now by using the full option
    name. We also take the opportunity to remove some
    redundant checks from the respective option handling
    code.

    Change-Id: I6f30060cec38733afa1211cb8e7bc57b66dead34
    Closes-Bug: #1506577

Changed in manila:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to manila (stable/liberty)

Fix proposed to branch: stable/liberty
Review: https://review.openstack.org/260088

Revision history for this message
Thierry Carrez (ttx) wrote : Fix included in openstack/manila 2.0.0.0b2

This issue was fixed in the openstack/manila 2.0.0.0b2 development milestone.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on manila (stable/liberty)

Change abandoned by Csaba Henk (<email address hidden>) on branch: stable/liberty
Review: https://review.openstack.org/260088
Reason: stable/liberty takes only critical fixes.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.