glusterfs vol based layout: Deleting a share created from snapshot should also delete its backend gluster volume

Bug #1506298 reported by karthick on 2015-10-15
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Shared File Systems Service (Manila)
Undecided
Csaba Henk

Bug Description

When a share is created from snapshot, a snap clone volume is created in the backend gluster cluster. However, when we delete the same share the backend volume created isn't deleted. The volume would remain dangling in the volume pool un-managed.

Hence, whenever a share created from snapshot is deleted, its corresponding backend gluster volume should also be deleted.

karthick (kramdoss) on 2015-10-15
tags: added: glusterfs

Fix proposed to branch: master
Review: https://review.openstack.org/237454

Changed in manila:
assignee: nobody → Csaba Henk (chenk)
status: New → In Progress

Reviewed: https://review.openstack.org/237454
Committed: https://git.openstack.org/cgit/openstack/manila/commit/?id=52bfb25a515850ce982ee3a11ca537132613fd18
Submitter: Jenkins
Branch: master

commit 52bfb25a515850ce982ee3a11ca537132613fd18
Author: Csaba Henk <email address hidden>
Date: Tue Oct 20 08:48:45 2015 +0200

    glusterfs/vol layout: remove manila-created vols upon delete_share

    With volume layout the volume we use to back a share can
    be pre-created (part of the volume pool provided for Manila),
    or can be created by Manila (that happens if share is created
    from snapshot, in which case the volume is obtained by performing
    a 'snapshot clone' gluster operation).

    In terms of resource management, pre-created volumes are owned
    by the pool, and Manila cloned ones are owned by Manila. So
    far we kept all the volumes upon giving up its use (ie. deleting
    the share it belonged to) -- we only ran a cleanup routine on them.
    However, that's appropriate action only for the pool owned ones.
    However, the ones we own should rather be extinguished to avoid
    a resource leak. This patch implements this practice by marking
    Manila owned volumes with a gluster user option.

    Closes-Bug: #1506298
    Change-Id: I165cc225cb7aca44785ed9ef60f459b8d46af564

Changed in manila:
status: In Progress → Fix Released

This issue was fixed in the openstack/manila 2.0.0.0b2 development milestone.

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers