"task_state" field of a share is not shown via API

Bug #1497352 reported by Valeriy Ponomaryov
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Shared File Systems Service (Manila)
Fix Released
High
Rodrigo Barbieri

Bug Description

After merge of commit [1] it is impossible to get via API value of "task_state" for any share.

The reason for it is that update of "view" part for API was marked as "experimental" and our core APIs "get" and "create" share do not satisfy this criterion. So, it is never attached to response.

[1] https://github.com/openstack/manila/commit/350dfb8b4a376607bcdbe7fb3d10a214dc0a3f94

Tags: api
tags: added: api
Changed in manila:
milestone: none → liberty-rc1
importance: Undecided → High
status: New → Triaged
assignee: nobody → Valeriy Ponomaryov (vponomaryov)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to manila (master)

Fix proposed to branch: master
Review: https://review.openstack.org/225241

Changed in manila:
assignee: Valeriy Ponomaryov (vponomaryov) → Rodrigo Barbieri (rodrigo-barbieri2010)
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to manila (master)

Reviewed: https://review.openstack.org/225241
Committed: https://git.openstack.org/cgit/openstack/manila/commit/?id=3085534f46292daa079b0c39d32b94edfb57333f
Submitter: Jenkins
Branch: master

commit 3085534f46292daa079b0c39d32b94edfb57333f
Author: Rodrigo Barbieri <email address hidden>
Date: Fri Sep 18 13:49:59 2015 -0300

    Fix experimental=True for view in microversion 2.5

    A previous patch added experimental=True to hide task_state field
    for any API call that would return share fields, such as "create"
    and "get" calls if different than microversion "2.5" with
    experimental=True. Turns out the field task_state should be
    returned always if microversion is "2.5" or above because it
    relates to a change in DB, not only to the usage of Share Migration
    feature. This patch fixes it by removing experimental=True
    dependency to show task_state field.

    Closes-bug: #1497352
    Change-Id: Ic07d63ebcfe25c1cfa3fac1e75e2e186fbcec25b

Changed in manila:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in manila:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in manila:
milestone: liberty-rc1 → 1.0.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.