Managing a 500 MB share results in 500 GB share in HDS HNAS Driver

Bug #1496917 reported by Rodrigo Barbieri
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Shared File Systems Service (Manila)
Fix Released
Critical
Alyson

Bug Description

Whenever a user wants to manage an existing share that has a registered quota of less than 1GB using HDS HNAS Driver, the driver recognizes the quota number as GB, but it may be KB or MB. This causes the Manila quota to be drastically reduced, exhausted or even prevent share from being managed. As an example, managing a 500 MB share results in 500 GB share in HDS HNAS Driver.

Revision history for this message
Erlon R. Cruz (sombrafam) wrote :

Quota/share can be in 'TB' as well.

Revision history for this message
Alyson (alyson-rodrigues-rosa) wrote :

When its in 'TB' we transform to 'GB' using something like "quota * units.Ki"

Changed in manila:
milestone: none → liberty-rc1
Changed in manila:
importance: Undecided → Critical
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to manila (master)

Fix proposed to branch: master
Review: https://review.openstack.org/224830

Changed in manila:
assignee: nobody → Alyson (alyson-rodrigues-rosa)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to manila (master)

Reviewed: https://review.openstack.org/224830
Committed: https://git.openstack.org/cgit/openstack/manila/commit/?id=dd77cf98c1018531d0e539e915b3421bd14fc3e8
Submitter: Jenkins
Branch: master

commit dd77cf98c1018531d0e539e915b3421bd14fc3e8
Author: Alyson Rosa <email address hidden>
Date: Thu Sep 17 13:14:08 2015 -0300

    Fix HDS HNAS manage incorrect share size

    Method get_quota does not handle quotas smaller than 1 GB.
    When the share quota is KB or MB, get_quota transforms everything to GB.
    It is impacting directly on managing shares.
    As an example, managing a 500 MB share results in 500 GB share in HDS HNAS
    Driver.
    The unit TB was already being transformed in GB.

    This patch implements a condition to deny share with quota smaller than
    1GB.

    Closes-bug: #1496917
    Change-Id: I73edc1f413bd307a856702f8a024a8b50886207b

Changed in manila:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in manila:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in manila:
milestone: liberty-rc1 → 1.0.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.