Logging missing value types

Bug #1494574 reported by Bridget McGinnis
12
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Cinder
Fix Released
Undecided
Bridget McGinnis
Ironic
Fix Released
Medium
Pavlo Shchelokovskyy
Magnum
Fix Released
Undecided
Peiyu Lin
OpenStack DBaaS (Trove)
Fix Released
Undecided
Amrith Kumar
OpenStack Heat
Fix Released
Medium
Sergey Kraynev
OpenStack Shared File Systems Service (Manila)
Fix Released
Undecided
Sergey Vilgelm
networking-midonet
Fix Released
Low
Sergey Vilgelm
neutron
Fix Released
Undecided
Sergey Vilgelm
os-brick
Fix Released
Undecided
Sergey Vilgelm
oslo.versionedobjects
Fix Released
Low
Sergey Vilgelm
tempest
Fix Released
Undecided
Ghanshyam Mann

Bug Description

There are a few locations in the code where the log string is missing the formatting type, causing log messages to fail.

FILE: ../OpenStack/cinder/cinder/volume/drivers/emc/emc_vnx_cli.py
                        LOG.debug('EMC: Command Exception: %(rc) %(result)s. '
FILE: ../OpenStack/cinder/cinder/consistencygroup/api.py
                            LOG.error(_LE("CG snapshot %(cgsnap) not found when "
                            LOG.error(_LE("Source CG %(source_cg) not found when "
FILE: ../OpenStack/cinder/cinder/volume/drivers/emc/emc_vmax_masking.py
                            "Storage group %(sgGroupName) "
FILE: ../OpenStack/cinder/cinder/volume/manager.py
                                        '%(image_id) will not create cache entry.'),

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder (master)

Fix proposed to branch: master
Review: https://review.openstack.org/222455

Changed in cinder:
assignee: nobody → Bridget McGinnis (bfmcginnis)
status: New → In Progress
Changed in heat:
assignee: nobody → Sergey Kraynev (skraynev)
importance: Undecided → Medium
status: New → Triaged
milestone: none → liberty-rc1
Revision history for this message
Sergey Vilgelm (sergey.vilgelm) wrote :

I have found the same problem in other openstack components: https://pastebin.com/DTc3QrX7

no longer affects: fuel
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to heat (master)

Fix proposed to branch: master
Review: https://review.openstack.org/222530

Changed in heat:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tempest (master)

Fix proposed to branch: master
Review: https://review.openstack.org/222550

Changed in tempest:
assignee: nobody → Ghanshyam Mann (ghanshyammann)
status: New → In Progress
Peiyu Lin (mathspanda)
Changed in magnum:
assignee: nobody → Peiyu Lin (mathspanda)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to magnum (master)

Fix proposed to branch: master
Review: https://review.openstack.org/222576

Changed in magnum:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cinder (master)

Reviewed: https://review.openstack.org/222455
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=3cd8dd67d12f727f0fad51ed0d34c174e85ce01e
Submitter: Jenkins
Branch: master

commit 3cd8dd67d12f727f0fad51ed0d34c174e85ce01e
Author: Bridget McGinnis <email address hidden>
Date: Thu Sep 10 23:35:05 2015 -0500

    Fixed missing log variable types

    There were several cases of log messages that were missing
    string formatting types. This patch adds the missing types.

    Change-Id: If4336dafeb455cc1edd958219b1ffdd50bb2ca05
    Closes-Bug: #1494574

Changed in cinder:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to magnum (master)

Reviewed: https://review.openstack.org/222576
Committed: https://git.openstack.org/cgit/openstack/magnum/commit/?id=9a210688ac1e5e0ef0fcb74ebeca517ed22eba2d
Submitter: Jenkins
Branch: master

commit 9a210688ac1e5e0ef0fcb74ebeca517ed22eba2d
Author: mathspanda <email address hidden>
Date: Fri Sep 11 19:37:09 2015 +0800

    Fix missing value types for log message

    This patch add missing value types for some log message of exception.

    Change-Id: Id40bf63134bef5e5156b4b690b9de050ccfcd02e
    Closes-Bug: #1494574

Changed in magnum:
status: In Progress → Fix Committed
Revision history for this message
Kevin Benton (kevinbenton) wrote :

the neutron examples didn't seem to be valid

no longer affects: neutron
Changed in ironic:
assignee: nobody → Pavlo Shchelokovskyy (pshchelo)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to ironic (master)

Fix proposed to branch: master
Review: https://review.openstack.org/222862

Changed in ironic:
status: New → In Progress
Revision history for this message
Sergey Vilgelm (sergey.vilgelm) wrote :

@Kevin benton, Neutron has a couple of wrong places. I've created a patch.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.openstack.org/222874

Changed in neutron:
assignee: nobody → Sergey Vilgelm (sergey.vilgelm)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron-fwaas (master)

Fix proposed to branch: master
Review: https://review.openstack.org/222875

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron-lbaas (master)

Fix proposed to branch: master
Review: https://review.openstack.org/222876

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-neutronclient (master)

Fix proposed to branch: master
Review: https://review.openstack.org/222878

Changed in python-neutronclient:
assignee: nobody → Sergey Vilgelm (sergey.vilgelm)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.openstack.org/222874
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=57b6a651a39099ea76178bdcea51b06bde587e25
Submitter: Jenkins
Branch: master

commit 57b6a651a39099ea76178bdcea51b06bde587e25
Author: Sergey Vilgelm <email address hidden>
Date: Sat Sep 12 21:55:01 2015 +0300

    Fix missing value types for log message

    This patch add missing value types for some log message of exception.

    Change-Id: Ie9f512bc804f0cd70df991b1910c975a2f9d6fcf
    Closes-Bug: #1494574

Changed in neutron:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to manila (master)

Fix proposed to branch: master
Review: https://review.openstack.org/222996

Changed in manila:
assignee: nobody → Sergey Vilgelm (sergey.vilgelm)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to trove (master)

Fix proposed to branch: master
Review: https://review.openstack.org/223000

Changed in trove:
assignee: nobody → Sergey Vilgelm (sergey.vilgelm)
status: New → In Progress
Revision history for this message
Sergey Vilgelm (sergey.vilgelm) wrote :
Changed in os-brick:
assignee: nobody → Sergey Vilgelm (sergey.vilgelm)
status: New → In Progress
Revision history for this message
Sergey Vilgelm (sergey.vilgelm) wrote :
Changed in networking-midonet:
assignee: nobody → Sergey Vilgelm (sergey.vilgelm)
status: New → In Progress
Revision history for this message
Sergey Vilgelm (sergey.vilgelm) wrote :
Changed in oslo.versionedobjects:
assignee: nobody → Sergey Vilgelm (sergey.vilgelm)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tempest (master)

Reviewed: https://review.openstack.org/222550
Committed: https://git.openstack.org/cgit/openstack/tempest/commit/?id=367c6935247c0f24c096f7b63a2e5128e5773153
Submitter: Jenkins
Branch: master

commit 367c6935247c0f24c096f7b63a2e5128e5773153
Author: ghanshyam <email address hidden>
Date: Fri Sep 11 18:51:02 2015 +0900

    Fix missing value types for log message

    This commit fix the missing value type in log message of exception.

    Change-Id: Ib052964e49ded2eb427d5b448241e25cbd066906
    Closes-Bug: #1494574

Changed in tempest:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to manila (master)

Reviewed: https://review.openstack.org/222996
Committed: https://git.openstack.org/cgit/openstack/manila/commit/?id=087fa055b5a6771efd7153e2c8b9b9487ff0a2d6
Submitter: Jenkins
Branch: master

commit 087fa055b5a6771efd7153e2c8b9b9487ff0a2d6
Author: Sergey Vilgelm <email address hidden>
Date: Mon Sep 14 10:48:41 2015 +0300

    Fix missing value types for log message

    This patch add missing value types for some log message of exception.

    Change-Id: I661d597f5b87923078cdf1556d72b28e7fa18b5f
    Closes-Bug: #1494574

Changed in manila:
status: In Progress → Fix Committed
Changed in heat:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (feature/pecan)

Fix proposed to branch: feature/pecan
Review: https://review.openstack.org/224334

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: feature/pecan
Review: https://review.openstack.org/224357

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on python-neutronclient (master)

Change abandoned by Sergey Vilgelm (<email address hidden>) on branch: master
Review: https://review.openstack.org/222878
Reason: I agree that we have to remove It.

no longer affects: python-neutronclient
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (feature/pecan)
Download full text (73.6 KiB)

Reviewed: https://review.openstack.org/224357
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=fdc3431ccd219accf6a795079d9b67b8656eed8e
Submitter: Jenkins
Branch: feature/pecan

commit fe236bdaadb949661a0bfb9b62ddbe432b4cf5f1
Author: Miguel Angel Ajo <email address hidden>
Date: Thu Sep 3 15:40:12 2015 +0200

    No network devices on network attached qos policies

    Network devices, like internal router legs, or dhcp ports
    should not be affected by bandwidth limiting rules.

    This patch disables application of network attached policies
    to network/neutron owned ports.

    Closes-bug: #1486039
    DocImpact

    Change-Id: I75d80227f1e6c4b3f5fa7762b8dc3b0c0f1abd46

commit db4a06f7caa20a4c7879b58b20e95b223ed8eeaf
Author: Ken'ichi Ohmichi <email address hidden>
Date: Wed Sep 16 10:04:32 2015 +0000

    Use tempest-lib's token_client

    Now tempest-lib provides token_client modules as library and the
    interface is stable. So neutron repogitory doesn't need to contain
    these modules.
    This patch makes neutron use tempest-lib's token_client and removes
    the own modules for the maintenance.

    Change-Id: Ieff7eb003f6e8257d83368dbc80e332aa66a156c

commit 78aed58edbe6eb8a71339c7add491fe9de9a0546
Author: Jakub Libosvar <email address hidden>
Date: Thu Aug 13 09:08:20 2015 +0000

    Fix establishing UDP connection

    Previously, in establish_connection() for UDP protocol data were sent
    but never read on peer socket. That lead to successful read on peer side
    if this connection was filtered. Having constant testing string masked
    this issue as we can't distinguish to which test of connectivity data
    belong.

    This patch makes unique data string per test_connectivity() and
    also makes establish_connection() to create an ASSURED entry in
    conntrack table. Finally, in last test after firewall filter was
    removed, connection is re-established in order to avoid troubles with
    terminated processes or TCP continuing sending packets which weren't
    successfully delivered.

    Closes-Bug: 1478847
    Change-Id: I2920d587d8df8d96dc1c752c28f48ba495f3cf0f

commit e6292fcdd6262434a7b713ad8802db6bc8a6d3dc
Author: YAMAMOTO Takashi <email address hidden>
Date: Wed Sep 16 13:20:51 2015 +0900

    ovsdb: Fix a few docstring

    Change-Id: I53e1e21655b28fe5da60e58aeeb7cbbd103ae014

commit c22949a4449d96a67caa616290cf76b67b182917
Author: fumihiko kakuma <email address hidden>
Date: Wed Sep 16 11:52:59 2015 +0900

    Remove requirements.txt for the ofagent mechanism driver

    It is no longer used.

    Related-Blueprint: core-vendor-decomposition
    https://blueprints.launchpad.net/neutron/+spec/core-vendor-decomposition

    Change-Id: Ib31fb3febf8968e50d86dd66e1e6e1ea2313f8ac

commit d1d4de19d85f961d388c91e70f31b3bafec418c5
Author: Kevin Benton <email address hidden>
Date: Thu Sep 3 20:25:57 2015 -0700

    Always return iterables in L3 get_candidates

    The caller of this function expects iterables.

    Closes-Bug: #1494996
    Change-Id: I3d103e63f4e127a77268502415c0ddb0d804b54a

commit 1ad6ac448067306...

tags: added: in-feature-pecan
Dmitry Tantsur (divius)
Changed in ironic:
importance: Undecided → Medium
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on neutron (feature/pecan)

Change abandoned by Doug Wiegley (<email address hidden>) on branch: feature/pecan
Review: https://review.openstack.org/224334

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to os-brick (master)

Reviewed: https://review.openstack.org/222998
Committed: https://git.openstack.org/cgit/openstack/os-brick/commit/?id=f5006ea10a729d62e59ea1f45dfa6b96a1d39ce7
Submitter: Jenkins
Branch: master

commit f5006ea10a729d62e59ea1f45dfa6b96a1d39ce7
Author: Sergey Vilgelm <email address hidden>
Date: Mon Sep 14 10:52:16 2015 +0300

    Fix missing value types for log message

    This patch add missing value types for some log message of exception.

    Change-Id: Ic9ccbad99aa8945c81c6539cb99ff0e3a45353c1
    Closes-Bug: #1494574

Changed in os-brick:
status: In Progress → Fix Committed
Changed in os-brick:
milestone: none → 0.5.0
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in manila:
milestone: none → liberty-rc1
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in heat:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in cinder:
milestone: none → liberty-rc1
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in neutron:
milestone: none → liberty-rc1
status: Fix Committed → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to ironic (master)

Reviewed: https://review.openstack.org/222862
Committed: https://git.openstack.org/cgit/openstack/ironic/commit/?id=0967238ad47cabccd1ecc2a4ef341120f410302f
Submitter: Jenkins
Branch: master

commit 0967238ad47cabccd1ecc2a4ef341120f410302f
Author: Pavlo Shchelokovskyy <email address hidden>
Date: Sat Sep 12 15:50:58 2015 +0300

    Fix string formatting issues

    if keyworded substitution is used, the formatter must be a dict
    (even for single element).

    Add a missing unit test for a code branch where a formatting
    error was found.

    Also, fix a tiny error message typo (missing space).

    Change-Id: Ib1649511b2613bc1a8ba52398543be0fdfefb8db
    Closes-Bug: #1494574

Changed in ironic:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to networking-midonet (master)

Reviewed: https://review.openstack.org/223001
Committed: https://git.openstack.org/cgit/openstack/networking-midonet/commit/?id=0257efa266a0403688e0dd556870467058c406b7
Submitter: Jenkins
Branch: master

commit 0257efa266a0403688e0dd556870467058c406b7
Author: Sergey Vilgelm <email address hidden>
Date: Mon Sep 14 11:02:26 2015 +0300

    Fix missing value types for log message

    This patch add missing value types for some log message of exception.

    Change-Id: Id7556e3ad04e0c8d593690f5d70bf4606bd3047a
    Closes-Bug: #1494574

Changed in networking-midonet:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in heat:
milestone: liberty-rc1 → 5.0.0
Thierry Carrez (ttx)
Changed in cinder:
milestone: liberty-rc1 → 7.0.0
Thierry Carrez (ttx)
Changed in neutron:
milestone: liberty-rc1 → 7.0.0
Thierry Carrez (ttx)
Changed in manila:
milestone: liberty-rc1 → 1.0.0
Changed in networking-midonet:
importance: Undecided → Low
milestone: none → 1.0.0
status: Fix Committed → Fix Released
Adrian Otto (aotto)
Changed in magnum:
milestone: none → mitaka-1
status: Fix Committed → Fix Released
Changed in oslo.versionedobjects:
importance: Undecided → Low
status: In Progress → Fix Committed
Changed in ironic:
status: Fix Committed → Fix Released
Revision history for this message
Doug Hellmann (doug-hellmann) wrote : Fix included in openstack/ironic 4.3.0

This issue was fixed in the openstack/ironic 4.3.0 release.

Changed in oslo.versionedobjects:
milestone: none → 1.1.0
status: Fix Committed → Fix Released
Changed in trove:
assignee: Sergey Vilgelm (sergey.vilgelm) → Morgan Jones (6-morgan)
Changed in trove:
assignee: Morgan Jones (6-morgan) → Amrith (amrith)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to trove (master)

Reviewed: https://review.openstack.org/223000
Committed: https://git.openstack.org/cgit/openstack/trove/commit/?id=667dc5f50c05b171e3acddf8100a5003a2a59044
Submitter: Jenkins
Branch: master

commit 667dc5f50c05b171e3acddf8100a5003a2a59044
Author: Sergey Vilgelm <email address hidden>
Date: Mon Sep 14 10:55:27 2015 +0300

    Fix missing value types for log message

    This patch add missing value types for some log message of exception.

    Change-Id: Ib4a1dea4cbfead8367884d9e6c34cb9b3f0a8d6a
    Closes-Bug: #1494574
    Co-Authored-By: Morgan Jones <email address hidden>

Changed in trove:
status: In Progress → Fix Released
Revision history for this message
Thierry Carrez (ttx) wrote : Fix included in openstack/trove 5.0.0.0b2

This issue was fixed in the openstack/trove 5.0.0.0b2 development milestone.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on neutron-lbaas (master)

Change abandoned by Armando Migliaccio (<email address hidden>) on branch: master
Review: https://review.openstack.org/222876
Reason: This review is > 4 weeks without comment, and failed Jenkins the last time it was checked. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and leaving a 'recheck' comment to get fresh test results.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on neutron-fwaas (master)

Change abandoned by Sergey Vilgelm (<email address hidden>) on branch: master
Review: https://review.openstack.org/222875

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/os-brick 0.5.0

This issue was fixed in the openstack/os-brick 0.5.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.