Missing share type check in manage_existing in share manager

[Clinton Knight]

In ShareManager::manage_existing(), there is a check for the DHSS mode of the driver but there is no check for the DHSS mode in the specified share type. This omission requires redundant checks in the drivers.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/222257

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/222257
Committed: https://git.openstack.org/cgit/openstack/manila/commit/?id=fd492fc11dc14f39c31f2451cb75e811802cc708
Submitter: Jenkins
Branch: master

commit fd492fc11dc14f39c31f2451cb75e811802cc708
Author: Clinton Knight <email address hidden>
Date: Wed Sep 9 11:27:40 2015 -0400

    Missing check in ShareManager::manage_existing()

    In ShareManager::manage_existing(), there is a check for the DHSS mode of
    the driver but there is no check for the DHSS mode in the specified share
    type. This omission requires redundant checks in the drivers. This patch
    adds the missing check to the share manager, removes the redundant checks
    from the drivers, and updates all relevant unit tests. Also, fix a
    couple minor tempest resource cleanup issues discovered while
    debugging this issue.

    Change-Id: Ib579fd0558e59c28777342bb9d36def12f6bf4da
    Closes-Bug: #1493869